git install fails in Dockerfile

Question

I'm trying to pull the repository I'm working on while doing a docker build, so I followed this tutorial so I added in my Dockerfile

# this is our first build stage, it will not persist in the final image
FROM ubuntu as intermediate

# install git
RUN apt-get update \
    apt-get upgrade \
    apt-get install git

# add credentials on build
RUN mkdir ~/.ssh && ln -s /run/secrets/host_ssh_key ~/.ssh/id_rsa

# make sure your domain is accepted
RUN touch /root/.ssh/known_hosts
RUN ssh-keyscan github.org >> /root/.ssh/known_hosts

RUN git clone [email protected]:my-repo/myproject.git

FROM ubuntu
# copy the repository form the previous image
COPY --from=intermediate /your-repo /srv/your-repo

In my docker-compose.yml I added

secrets:
  host_ssh_key:
    file: ~/.ssh/id_rsa

And I'm adding

secrets:
  - host_ssh_key

In one of the service.

Since this is only for my local use (I don't plan on deploying or using this for the production, I just want to test it out) it's fine to use it this way - if it'll work because currently the build fails at the git install stage with error

E: The update command takes no arguments

ERROR: Service 'web' failed to build: The command '/bin/sh -c apt-get update apt-get upgrade apt-get install git' returned a non-zero code: 100

What am I missing?

Any chance you could accept an answer? So that it indicates to others that some solution was helpful for you. Would be great if you did on all your question that have answers. — Kevin Kopf
– Kevin Kopf, Commented Apr 16, 2019 at 10:22
Sure, even though in the end I did it differently. Thanks for the help :) — dingo_d
– dingo_d, Commented Apr 16, 2019 at 12:53
Yeah its fine for local, and in fact not even a terrible idea for a dev server (But NOT staging or production!!!!) — Shayne
– Shayne, Commented Jul 15, 2022 at 3:24

Steven Kryskalla · Accepted Answer · 2018-12-01 01:35:02Z

142

You are overanalyzing this. It's just a simple typo. Should be:

RUN apt-get update && \
    apt-get upgrade -y && \
    apt-get install -y git

Those are 3 separate commands.

edited Dec 1, 2018 at 1:35

Steven Kryskalla

14.8k2 gold badges42 silver badges42 bronze badges

answered Jun 13, 2018 at 12:45

Kevin Kopf

14.3k15 gold badges57 silver badges69 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

dingo_d Over a year ago

Still getting The command '/bin/sh -c apt-get update && apt-get upgrade && apt-get install git' returned a non-zero code: 1

Kevin Kopf Over a year ago

It's another issue, now apt-get install is waiting for you to submit the installation. So you should add -y after install. From your typo it seems to me like you don't know how to work with Linux. Maybe you should read everything around apt-get?

dingo_d Over a year ago

I'll try with the flag, but overall I'll probably just skip the git clone in the build process. At least that's what the devops is doing. I'm just testing the docker out, not my main area of expertise :D

itzhar Over a year ago

in node:alpine: RUN apk update && \ apk upgrade && \ apk add git

Zhivko.Kostadinov Over a year ago

Run update after git installation. Try that one: RUN apt-get install --assume-yes git && apt-get update && apt-get clean all

Jairo Lozano · Accepted Answer · 2020-05-18 18:47:07Z

21

For those working with alpine images, RUN apk add --no-cache git did the trick for me.

answered May 18, 2020 at 18:47

Jairo Lozano

4,5914 gold badges24 silver badges31 bronze badges

1 Comment

Trapcode Over a year ago

Thank You this saved the some time. Please why did you use ---no-cache?

Nicolás Alarcón Rapela · Accepted Answer · 2019-09-08 12:29:13Z

14

Some thoughts:

1. Replace apt-get install git with apt-get install --assume-yes git. Without the --assume-yes it will prompt you for confirmation, which you are unable to give and it will be smart enough to figure that out and assume you meant "NO".
1. You added the ssh key, but did you confirm it was 0600. I would just copy it and specifically chmod 0600 ~/.ssh/id_rsa to be sure.

Overall, your Dockerfile looks very clever and I got some fresh ideas from reading it.

edited Sep 8, 2019 at 12:29

Nicolás Alarcón Rapela

3,0621 gold badge21 silver badges35 bronze badges

answered Jun 13, 2018 at 13:48

emory

10.9k2 gold badges32 silver badges58 bronze badges

2 Comments

emory Over a year ago

Just read the tutorial - very good. They use the -y switch. I use the --assume-yes switch. They are synonyms and I think that is what you are missing. If you supplied a valid 'id_rsa' file then my second point is not applicable.

Kevin Kopf Over a year ago

your edit to the question should be reverted, it clearly conflicts with author's intent.

Collectives™ on Stack Overflow

git install fails in Dockerfile

3 Answers 3

5 Comments

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

5 Comments

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related