Binding background color doesn't work

Question

I am trying to set background color of some icon via binding, but I'm probably missing something and don't know what.

The xaml:

<materialDesign:PackIcon x:Name="SaveIcon" Kind="ContentSave" 
                         Height="25" Width="25" Background="{Binding Background}" />

Code behind:

public Page6()
{
    InitializeComponent();
    DataContext = this;
    Background = "Red";
}

private string _background;
public string Background
{
    get
    {
        return _background;
    }

    set
    {
        _background = value;
        OnPropertyChanged();
    }
}

public event PropertyChangedEventHandler PropertyChanged;
private void OnPropertyChanged([CallerMemberName] string propertyName=null)
{
        PropertyChanged?.Invoke(this , new PropertyChangedEventArgs(propertyName));
}

But this don't do nothing, I mean there is no background color.

I think this is because Background property is of type Brush, not string, but I can't test it right now — vasily.sib
– vasily.sib, Commented May 22, 2018 at 11:17
You should see binding errors in Output window during debugging. — Sinatr
– Sinatr, Commented May 22, 2018 at 11:19

Scath · Accepted Answer · 2018-05-22 14:50:40Z

1

There is already Brush Background property in Control class. your string Background property hides base property, but binding Background="{Binding Background}" still picks up the base property.

You can remove string Background completely and use Brush Background, or rename your new property.

public Page6()
{
    InitializeComponent();
    DataContext = this;
    BackColor = "Red";
}

private string _background;
public string BackColor
{
        get
        {
            return _background;
        }

        set
        {
            _background = value;
            OnPropertyChanged();
        }
}

Change binding:

Background="{Binding BackColor}"

edited May 22, 2018 at 14:50

Scath

3,81710 gold badges32 silver badges40 bronze badges

answered May 22, 2018 at 11:44

ASh

35.9k9 gold badges68 silver badges89 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

mm8 Over a year ago

@PabloEscobar: Did you really bind to "BackColor"?

nuuse · Accepted Answer · 2018-05-22 11:37:04Z

1

change your Background property to

private SolidColorBrush _background;
public SolidColorBrush Background
{
    get
    {
        return _background;
    }

    set
    {
        _background = value;
        OnPropertyChanged();
    }
}

and change Background = "Red" to Background = new SolidColorBrush(Colors.Red);

answered May 22, 2018 at 11:37

nuuse

1091 silver badge11 bronze badges

Collectives™ on Stack Overflow

Binding background color doesn't work

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related