Python while loop with 2 conditions for variables

IMHO I think using while True in this kind of situation is not good practice.

I would suggest you to either check beforehand each one is the smallest using min(moneyihave, coffee) and then create a loop using the range method:

min_val = min(moneyihave, coffee)
for i in range(0, min_val):
    print(i) # Goes from 0 to min_val

The other way I would suggest you is to directly set the loop conditions in the while statement:

# Since you sell coffee's without checking if you still have some, the condition should be coffee > 0.
while moneyihave >= 0 and coffee > 0:
    # Do stuff...
    # Deduct variables:
    moneyihave -= 1
    coffee -= 1

But, looking at your code I can see some other problems:

• You have a coffeeprice but never uses it. I assume your intention is to deduct it from moneyihave each time a 'customer' buys a coffee.
• The user input the money on every loop iteration, but this inputed value is only used to check the first if...else block. I think a bit confusing having the money value setted every time but deducting some amount from moneyihave.
• you have: print('you have {} left in your pocket'.format(moneyihave-200)) after doing moneyihave = moneyihave - 200, this way you are showing to the user an incorrect amount.
• The phrase print('our coffee is 300 dollars') does not check with the provided coffeeprice. Again, I think the problem here is not using this variable

Also, on your first if...else block, both on if and elif you spend one coffee and some money, thus I would recommend refactoring for something like:

# Spend money if possible
if money >= 200:
    coffee = coffee - 1
    moneyihave = moneyihave - 200 # I think here you should use coffeeprice
else:
    print('our coffee is 300 dollars') # I think here you should use coffeeprice
    print('we have {} coffees left'.format(coffee))
    print('you have {} left in your pocket'.format(moneyihave)) # Since he can't have negative money, this should always be 0

# User still have money left
if moneyihave > 0:
    print('please take your change {} and here is your coffee'.format(money-200))        
    print('you have {} left in your pocket'.format(moneyihave-200))
else:
    print('here is your coffee, we have {} coffees left'.format(coffee))
    print('you have {} left in your pocket'.format(moneyihave-200))

I edited your code and this seems to work. The issue is that when you formatted the code, you used .format(moneyihave-200). So you were essentially subtracting 400 initially when you printed the results, although you were only subtracting 200. Your printed value wasn't matching the actual value basically. The code below will simplify this and give you the output you are seeking:

coffee = 20
coffeeprice = 200
moneyihave = 40000

while True:
    money = int(input('insert your money: '))
    if money == 200:
        coffee -= 1
        moneyihave -= 200

        print('here is your coffee, we have {} coffees left'.format(coffee))
        print('you have {} left in your pocket'.format(moneyihave)) 


    else:

        print('our coffee is 200 dollars')
        print('we have {} coffees left'.format(coffee))
        print('you have {} left in your pocket'.format(moneyihave))


   if coffee <= 0:      

      print('please come back, we do not have coffee anymore')
      break

   elif moneyihave <=0:
      print('no more money')
      break

And here is your output each time we iterate through the loop:

insert your money: 200
here is your coffee, we have 19 coffees left
you have 39800 left in your pocket
insert your money: 200
here is your coffee, we have 18 coffees left
you have 39600 left in your pocket
insert your money: 200
here is your coffee, we have 17 coffees left
you have 39400 left in your pocket
insert your money: 200

And at the end we break out of the loop:

you have 0 left in your pocket
no more money
>>>