ASP.Net MVC - How to display string from view model inside html tag?

Question

<span class="text-danger">
@{
    if (Model.uploadErrorMessage != null)
    {
        if (!string.IsNullOrEmpty(Model.uploadErrorMessage))
        {
            Model.uploadErrorMessage;
        }
    }
}
</span>

Given code above, how do I display Model.uploadErrorMessage inside <span> tag?

Currently it give me this error on Model.uploadErrorMessage:

Only assignment, call, increment, decrement, and new object expressions can be used as a statement

Use <text>Html.Raw(Model.uploadErrorMessage)</text> or just <text>@Model.uploadErrorMessage</text>. — Tetsuya Yamamoto
– Tetsuya Yamamoto, Commented Apr 27, 2018 at 9:40
The outer if statement is made redundant by the inner one, and you can remove them both anyway - see my answer. — DavidG
– DavidG, Commented Apr 27, 2018 at 9:45

Van VO · Accepted Answer · 2018-04-27 15:26:20Z

5

Put your span tag inside if statement

@{
    if (Model.uploadErrorMessage != null)
    {
        if (!string.IsNullOrEmpty(Model.uploadErrorMessage))
        {
            <span class="text-danger">@Model.uploadErrorMessage</span>
        }
    }
}

answered Apr 27, 2018 at 15:26

Van VO

6353 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

DavidG · Accepted Answer · 2018-04-27 09:44:20Z

4

All of those if statements are completely unnecessary anyway, you can simplify the entire thing to this:

<span class="text-danger">@Model.uploadErrorMessage</span>

answered Apr 27, 2018 at 9:44

DavidG

120k13 gold badges232 silver badges239 bronze badges

2 Comments

CodeNotFound Over a year ago

I may put at least one if that embrace the span and not adding an empty DOM to the page when the message is null or empty:-)

DavidG Over a year ago

@CodeNotFound Well yes, around the span would be different, but it's possible the empty span is required due to some Javascript thing perhaps.

G43beli · Accepted Answer · 2018-04-27 09:42:25Z

0

use the "@"-symbol to write your variable value to the view:

for example:

<span>This is the error: @(Model.uploadErrorMessage)</span>

answered Apr 27, 2018 at 9:42

G43beli

4,0014 gold badges25 silver badges29 bronze badges

Comments

manish · Accepted Answer · 2018-04-27 10:09:14Z

-1

~~@Html.Raw(Model.uploadErrorMessage)~~

you can simply put @Model.uploadErrorMessage

Edit: XSS vulnerability fix, based on @DavidG's comment.

edited Apr 27, 2018 at 10:09

answered Apr 27, 2018 at 9:41

manish

1,4588 silver badges13 bronze badges

7 Comments

DavidG Over a year ago

That's a bit dangerous though, would absolutely not recommend doing it that way. See here: stackoverflow.com/questions/11144943/…

manish Over a year ago

thanks @DavidG, would you mind elaborating a bit on That's a bit dangerous

DavidG Over a year ago

Yes, see the link I gave, and here kevinchalet.com/2018/01/09/…

DavidG Over a year ago

Well now your answer is the same as the existing one, and the big "edit" banner is not needed.

manish Over a year ago

yeah, that'll help others

|

Collectives™ on Stack Overflow

ASP.Net MVC - How to display string from view model inside html tag?

4 Answers 4

Comments

2 Comments

Comments

7 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

2 Comments

Comments

7 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related