How to get the JSON representation of an object with an array variable

Question

I have this class with three variables, one of them being an array. I have written a method that I'll use inside json_encode().

public function getJSONString(){
     return [
         'id' => $this->id,
         'name' => $this->name,
         'books' => $this->books
     ];
}

books is an array of Book objects. Each Book object also has the same exact method but then with its own variables.

public function getJSONString(){
    return [
        'id' => $this->id,
        'title' => $this->title
    ];
}

When I call print(json_encode($author->getJSONString())) I recieve this:

{"id":"1","name":"name1","books":[{},{}]}

Any idea why books remains empty? Thanks in advance!

Probably $this->books is empty. Check if it's empty var_dump($this->books) and check the code that sets it's value may be it is executing after you called getJSONString() — Accountant م
– Accountant م, Commented Apr 21, 2018 at 18:53
Books are empty because they're empty initially. print_r() your variable and see. — u_mulder
– u_mulder, Commented Apr 21, 2018 at 18:57

Jonathan Lam · Accepted Answer · 2018-04-21 18:58:52Z

2

You will need to use the Books' getJSONString() methods as well. This will make the the books property equal to an array of JSON-encode-able objects.

In the author's getJSONString() method:

public function getJSONString(){
     return [
         'id' => $this->id,
         'name' => $this->name,
         'books' => array_map(function($book) { return $book->getJSONString(); }, $this->books)
     ];
}

I am not fluent in PHP, but you can get the idea from this. It maps a function to get the getJSONString() over the books array.

edited Apr 21, 2018 at 18:58

answered Apr 21, 2018 at 18:42

Jonathan Lam

17.5k17 gold badges72 silver badges99 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

David - ACA Group Over a year ago

I get the idea of calling getJSONString of every book but I think in this example it's calling the wrong getJSONString method. See the class Book has it's own implementation of the method, and right now I think it keeps calling the getJSONString in the same class where $books is declared?

Jonathan Lam Over a year ago

@Notorious Oops, I made a silly mistake in my first code. I changed it so that it uses $book->getJSONString(). Tell me if it works now.

David - ACA Group Over a year ago

Works fine now. Appreciate the help alot!

Jonathan Lam Over a year ago

@Notorious Glad I helped!

abeyaz Over a year ago

This is not a good way to do it. Using JsonSerializer is the cleaner way to go. See my answer.

|

abeyaz · Accepted Answer · 2018-04-21 19:04:55Z

0

You should definitely use JsonSerializable interface.

class Book implements JsonSerializable 
{
    public function jsonSerialize() {
        return [
           'id' => $this->id,
           'title' => $this->title
        ];
    }
}

When you call json_encode for an object of this class or anything contains that, php will call your jsonSerialize method. Similar to what you are trying to do, but this is the language specific and right way to do it. Other languages like C# has similar interfaces too.

edited Apr 21, 2018 at 19:04

answered Apr 21, 2018 at 19:02

abeyaz

3,1842 gold badges19 silver badges21 bronze badges

Collectives™ on Stack Overflow

How to get the JSON representation of an object with an array variable

2 Answers 2

7 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related