Insert specific input into a database using c++ sqlite

Question

I'm quite new at c++ and was wondering if someone could help me out with the piece of code, basically it has no errors but what I'm trying to do is when an user inputs their name, sex, race it'll save it to a database, it creates the database but does not create the table neither does it insert the values name sex race

void Intro()
{

sqlite3 *db;
sqlite3_stmt * st;
string sql3;



    cout << "Enter the name of your hero:\n";
    cin >> name;
    cout << "Enter hero sex: (M/F)\n";
    cin >> sex;
    cout << "Enter hero race: (e.g dwarf,elf,human)\n";
    cin >> race;

   sql3 = "CREATE TABLE PERSONS("  
         "ID INT PRIMARY        KEY      NOT NULL," 
         "NAME         TEXT     NOT NULL," 
         "SEX          TEXT     NOT NULL," 
         "RACE         TEXT     NOT NULL,"

   ;
  string sql = "INSERT INTO PERSONS (name,sex,race) VALUES (" + name + ',' + sex + ',' + race + ");";

    if(sqlite3_open("pw.db", &db) == SQLITE_OK)
    {
        sqlite3_prepare( db, sql.c_str(), -1, &st, NULL);
        sqlite3_bind_text(st, 1, name.c_str(), name.length(), SQLITE_TRANSIENT);
        sqlite3_bind_text(st, 2, sex.c_str(), sex.length(), SQLITE_TRANSIENT);
        sqlite3_bind_text(st, 3, race.c_str(), race.length(), SQLITE_TRANSIENT);
        sqlite3_step( st );
    }

Still stuck on this :(

aaromated
– aaromated

2018-03-12 06:10:50 +00:00
Commented Mar 12, 2018 at 6:10 — aaromated
– aaromated, Commented Mar 12, 2018 at 6:10
All function calls must be checked for errors.

CL.
– CL.

2018-03-12 17:42:00 +00:00
Commented Mar 12, 2018 at 17:42 — CL.
– CL., Commented Mar 12, 2018 at 17:42

Tim Biegeleisen · Accepted Answer · 2018-03-12 01:55:35Z

1

I am not expert in the SQLite for C++ API, but I can see what appears to be a problem with your prepared statement. You should be using ? placeholders in the INSERT statement, into which you bind actual values later on:

if (sqlite3_open("pw.db", &db) == SQLITE_OK)
{
    string sql = "INSERT INTO PERSONS (name, sex, race) VALUES (?, ?, ?);";
    int rc = sqlite3_prepare(db, sql.c_str(), -1, &st, NULL);
    if (rc == SQLITE_OK)
    {
        sqlite3_bind_text(st, 1, name.c_str(), name.length(), SQLITE_TRANSIENT);
        sqlite3_bind_text(st, 2, sex.c_str(),  sex.length(),  SQLITE_TRANSIENT);
        sqlite3_bind_text(st, 3, race.c_str(), race.length(), SQLITE_TRANSIENT);
        sqlite3_step(st);
        sqlite3_finalize(st);
    }
}

answered Mar 12, 2018 at 1:55

Tim Biegeleisen

526k32 gold badges323 silver badges399 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Insert specific input into a database using c++ sqlite

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related