JavaScript heap out of memory (Nodejs)

Question

i have a problem, my Java Script runs out of memory and i dont know why. Memory usage jumps to almost 2gB when I start the code. Currently if i comment out this part of my code it works fine:

var way = [];
for(var x = 0;x<=way1.length > way2.length?way1.length:way2.length;x++){
    way.push(way1[x]);
    way.push(way2[x]);
}

otherwise it will crashe.

Thanks for help.

Without looking deeply in the code. Why the hell do you have such complex expression inside the for? That is probably your issue — Igal S.
– Igal S., Commented Feb 25, 2018 at 8:55

Igal S. · Accepted Answer · 2018-02-25 08:58:37Z

3

The expression inside the loop does not do what you think it does.

x <= way1.length > way2.length? way1.length : way2.length

What you probably meant

x <= (way1.length > way2.length? way1.length : way2.length)

It actually does

(x <= way1.length > way2.length) ? way1.length : way2.length

Which always return the same number. Either way1.length or way2.length - which is always true. And the loops goes infinity.

answered Feb 25, 2018 at 8:58

Igal S.

14.8k5 gold badges34 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jiby Jose · Accepted Answer · 2018-02-25 09:00:20Z

1

Your condition is very confusing, and is most probably producing a wrong result, maybe you should do

var way = [];
for(var x = 0, length = Math.max(way1.length, way2.length); x <= length; x++){
    way.push(way1[x]);
    way.push(way2[x]);
}

answered Feb 25, 2018 at 9:00

Jiby Jose

3,8564 gold badges26 silver badges32 bronze badges

Comments

radhey shyam · Accepted Answer · 2018-02-25 08:56:23Z

0

Simplify the loop condition first, I think condition making your program out of memory

answered Feb 25, 2018 at 8:56

radhey shyam

7696 silver badges9 bronze badges

1 Comment

Simon Schoerghuber Over a year ago

Ok, i´ll try it.

Collectives™ on Stack Overflow

JavaScript heap out of memory (Nodejs)

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related