Displaying the contents of a specified text file in c++

Question

I am trying to make this program ask the user to enter the name of a textfile and have it display the results that are in the textfile. When I run this program, its somewhat successful in the sense that it recognizes the textfile, but it outputs strange results. For example, I'm trying to get it to output the contents of a certain file that contains:

but it instead outputs just:

0 0 0

End of file reached

I really new to c++ but I've been trying to figure out for hours why my program isn't working and this is only a small chunk of the final program anyways. Thank you!

#include <iostream>
#include <fstream>
#include <string>
#include <iomanip>
using namespace std;


int main()
{
    int  count, firstMinute, secondMinute, numOfDishes;
    string inputFileName;
    ifstream inputFile;

    cout << "Input file name: ";
    getline(cin, inputFileName);

    //Open input file
    inputFile.open(inputFileName);

    //check if messed up

    if (!inputFile.is_open())
    {
        cout << "Unable to open file." << endl;
        exit(1);
    }

    while (inputFile >> firstMinute >> secondMinute >> numOfDishes) 
    { 

        cout << firstMinute << ' ' << secondMinute << ' ' << numOfDishes << 
' ' << '\n';

    }

    cout << "End of file reached" << endl;

    inputFile.clear();
    inputFile.seekg(0);

    inputFile.close();
    return 0;
}

Recommended reading: Why is iostream::eof inside a loop condition considered wrong? — user4581301
– user4581301, Commented Feb 9, 2018 at 5:02
Where are you setting firstMinute secondMinute and numOfDishes? Just once? — user7287311
– user7287311, Commented Feb 9, 2018 at 5:03

score 1 · Accepted Answer · 2022-09-14 06:27:32Z

1

First of all, while(!inputFile.eof()) is not a good idea. More on that here.

Also, you simply never changed the value of firstMinute, secondMinute, and numOfDishes. Did you forget to do that in the loop?

I would have simply used the extraction operator instead of getline() like this:

while(inputFile >> firstMinute >> secondMinute >> numOfDishes)
{
    cout << firstMinute << ' ' << secondMinute << ' ' << numOfDishes << '\n';
}

edited Sep 14, 2022 at 6:27

answered Feb 9, 2018 at 5:30

user9254539

Sign up to request clarification or add additional context in comments.

2 Comments

user8930130 Over a year ago

I replaced my while loop with yours but I am getting out put that now says just 0 0 0 still.

user8930130 Over a year ago

Ok I will edit my original question with the new code

Collectives™ on Stack Overflow

Displaying the contents of a specified text file in c++

1 Answer 1

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related