foreach loop populate array for call_user_func_array

Question

I am using a foreach loop to populate an array with parameter types and parameter values before it inserts into the database. Everything works fine and posts to the db, but I can't figure out why it sends both values as the same when they are added (as a reference) to the array. I have tired calling unset(); but it doesn't do the trick.

function insertUsers($db, $sql, $vals){
     $stmt= $db->prepare($sql);
     $types='';
     $types= $types ?: str_repeat("s", count($vals));
     $inputArray [] = &$types;

     foreach($vals as $key=>$value){
         $inputArray[]= &$value;
         unset($key);
     }
     print_r($inputArray);

     call_user_func_array(array($stmt, 'bind_param'), $inputArray);
     $stmt->execute();
     $stmt->close();
 }

The result ends being:

Array
(
  [0] => ss
  [1] => tyuty (note this value changes to the last value)
  [2] => tyuty 
)

If you want to use references to pass the result to wherever you call the function from, you need to use & on every step. I.e. insertUsers($db, $sql, &$vals), foreach($vals as $key=>&$value). — jh1711
– jh1711, Commented Dec 15, 2017 at 20:47

Death-is-the-real-truth · Accepted Answer · 2021-01-04 10:08:26Z

4

You need to remove & from there inside foreach();-

foreach($vals as $key=>&$value){ // put & here
  $inputArray[]= $value; // remove & from here and unset() not needed actually
}

And Add & inside function argument too:-

function insertUsers($db, $sql, &$vals){

edited Jan 4, 2021 at 10:08

answered Dec 15, 2017 at 20:24

Death-is-the-real-truth

72.3k10 gold badges59 silver badges105 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dharman · Accepted Answer · 2021-01-04 11:47:20Z

0

It's much better to avoid using call_user_func_array() for exactly this reason. Since PHP 5.6 we have a splat operator (...) that helps you avoid all this hassle.

Simply unpack the array directly in the call to bind_param().

function insertUsers($db, $sql, $vals){
    $stmt = $db->prepare($sql);
    $stmt->bind_param(str_repeat("s", count($vals)), ...$vals);
    $stmt->execute();
}

answered Jan 4, 2021 at 11:47

Dharman♦

33.9k27 gold badges106 silver badges157 bronze badges

Collectives™ on Stack Overflow

foreach loop populate array for call_user_func_array

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related