External powershell scripts only run once when action called

Question

I am trying to call an outside ps script to run every time files are created. The monitoring and logging of files work well, but the Invoke-Expression of running the external script only runs one time even if more files are created. How do I run the external script with every time a new file is created.

### SET FOLDER TO WATCH + FILES TO WATCH + SUBFOLDERS YES/NO
    $watcher = New-Object System.IO.FileSystemWatcher
    $watcher.Path = "c:\mypath"
    $watcher.Filter = "*.txt*"
    $watcher.IncludeSubdirectories = $true
    $watcher.EnableRaisingEvents = $true  

### DEFINE ACTIONS AFTER AN EVENT IS DETECTED
    $action = { $path = $Event.SourceEventArgs.FullPath                
                $changeType = $Event.SourceEventArgs.ChangeType
                $logline = "$(Get-Date), $changeType, $path"
                Add-content "C:\mypath\log.txt" -value $logline
                Invoke-Expression (start powershell ("C:\MyOtherScript.ps1")) ###### This only runs one time even if file is changes and logged
              }

### DECIDE WHICH EVENTS SHOULD BE WATCHED

    Register-ObjectEvent $watcher "Created" -Action $action
    while ($true) {sleep 5}

EDIT: This got it working incase anyone find themselves here looking to solve the porblem

### SET FOLDER TO WATCH + FILES TO WATCH + SUBFOLDERS YES/NO
    $watcher = New-Object System.IO.FileSystemWatcher
    $watcher.Path = "c:\mypath"
    $watcher.Filter = "*.txt*"
    $watcher.IncludeSubdirectories = $true
    $watcher.EnableRaisingEvents = $true  

### DEFINE ACTIONS AFTER AN EVENT IS DETECTED
    $action = { $path = $Event.SourceEventArgs.FullPath                
                $changeType = $Event.SourceEventArgs.ChangeType
                $logline = "$(Get-Date), $changeType, $path"
                Add-content "C:\mypath\log.txt" -value $logline
                Start-Process powershell -argument "C:\MyOtherScript.ps1"
              }

### DECIDE WHICH EVENTS SHOULD BE WATCHED

    Register-ObjectEvent $watcher "Created" -Action $action
    #while ($true) {sleep 5}

What's the purpose of your loop at the end? Also, why are you using Invoke-Expression instead of just Start-Process — Maximilian Burszley
– Maximilian Burszley, Commented Nov 15, 2017 at 18:49
The loop at the end was in to original code to monitor files her superuser.com/questions/226828/… — Tim Truty
– Tim Truty, Commented Nov 15, 2017 at 19:00
In searching for how to do this I found 'Invoke-expression' or 'invoke-item' were the methods of running other scripts. I am new to powershell. — Tim Truty
– Tim Truty, Commented Nov 15, 2017 at 19:01
I was able to get it working with using Start-Process powershell -argument "C:\MyOtherScript.ps1" and commenting out the while ($true) {sleep 5} — Tim Truty
– Tim Truty, Commented Nov 15, 2017 at 19:56

Maximilian Burszley · Accepted Answer · 2017-11-15 20:37:27Z

1

Invoke-Expression is not recommend over using & due to security concerns. In your example, however, I'd suggest Start-Process:

Start-Process -FilePath 'powershell' -ArgumentList @('-File','"C:\MyOtherScript.ps1"')

answered Nov 15, 2017 at 20:37

Maximilian Burszley

19.9k7 gold badges39 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

External powershell scripts only run once when action called

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related