Add multiple values to array through function

Question

I'm trying to make a function which accepts a value and echo them in the end.

Here's an example:

function number_of_files ($name) {
    $name_of_files = array($name);
    var_dump ($name_of_files);
}

And I'm using this function as

number_of_files("file.png");
number_of_files("audio.mp3");

I'm expecting the following output:

  Array (
    [0] => file.png
    [1] => audio.mp3
)

Any suggestions why is it not working?

What are you going to use this function for? I don't think this is what you actually want to do. — bassxzero
– bassxzero, Commented Nov 13, 2017 at 15:48
Maybe, it's a good case for using a class with a static array? — splash58
– splash58, Commented Nov 13, 2017 at 16:00
@bassxzero I actually wanted to use $name_of_file as multidimensional array. With name and path of the file. — Dev Aggarwal
– Dev Aggarwal, Commented Nov 14, 2017 at 16:23
@splash58 mind suggesting me a good tutorial on classes? Cheers! — Dev Aggarwal
– Dev Aggarwal, Commented Nov 14, 2017 at 16:24

vaso123 · Accepted Answer · 2017-11-13 15:54:19Z

3

Nope. You are overwrite your $name_of_files every time. That variable in the functions scope.

Use this:

function number_of_files ($name, &$name_of_files) {
    array_push($name_of_files, $name);
}

$name_of_files = number_of_files('file.mpg', $name_of_files);
$name_of_files = number_of_files('audio.mp3', $name_of_files);
var_dump ($name_of_files);

Now you are using your array as a reference.

EDIT:

If you do not want to overwrite your original array, you can return:

function number_of_files ($name, $name_of_files) {
    array_push($name_of_files, $name);
    return $name_of_files;
}

But let's note, in the second case I did not used the & sign before the $name_of_files function argument. That is the reference marker.

You can read it here: http://php.net/manual/en/language.references.pass.php

edited Nov 13, 2017 at 15:54

answered Nov 13, 2017 at 15:49

vaso123

12.4k4 gold badges37 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

bassxzero Over a year ago

What if he doesn't want to update the array passed into the function? What if he is looking to update a static array inside the function?

vaso123 Over a year ago

then push and return.

bassxzero Over a year ago

And if he didn't actually want to return anything? Say he just wanted the array to be accessible, with the correct values, inside the function body?

vaso123 Over a year ago

My answer is point to the scope issue. If after this OP can not handle what he/she wants, I am so sorry. You have the possibilities to write your own answer, or you can ask him/her, what he/she really need.

bassxzero Over a year ago

@vaso123 "or you can ask him/her, what he/she really need." that's my point. I did ask him, and you posted your answer before he answered.

|

Collectives™ on Stack Overflow

Add multiple values to array through function

1 Answer 1

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related