Using functions and arrays

Question

My little program below shall take 5 numbers from the user, store them into an array of integers and use a function to print them out. Sincerly it doesn't work and my output is always "00000". I can't find a mistake, so i would be glad about any advice. Thanks.

#include <stdio.h>

void printarray(int intarray[], int n)
{
    int i;
    for(i = 0; i < n; i ++)
    {
        printf("%d", intarray[i]);
    }
}

int main ()    
{
    const int n = 5;
    int temp = 0;
    int i;
    int intarray [n];
    char check;

    printf("Please type in your numbers!\n");

    for(i = 0; i < n; i ++)
    {
        printf("");
            scanf("&d", &temp);         
        intarray[i] = temp;


        getchar();
        getchar();

    }

    printf("Do you want to print them out? (yes/no): ");
        scanf("%c", &check);

        if (check == 'y')
            printarray(intarray, n);


    getchar();
    getchar();

    return 0;
}

Carl Norum · Accepted Answer · 2011-01-15 05:39:14Z

5

You want %d, not &d, in your scanf() format string. This bug is the kind that is very easy to identify by using a debugger - I recommend learning how to use whichever one works best with the rest of your development system.

Compiling with more warnings turned on would probably have detected this one, too. Something like "too many arguments for format".

edited Jan 15, 2011 at 5:39

answered Jan 15, 2011 at 5:33

Carl Norum

226k42 gold badges442 silver badges480 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Ordo Over a year ago

Thank you but now i have another problem. The input is not printed out by the function. So even the "00000" is missing now.

Carl Norum Over a year ago

@Ordo, the rest of your program looks fine. I tested it here and things look good (I did have to take out one of each set of doubled-up getchar() calls because I'm not on a windows machine). Did you try setting up a debugger?

Ordo Over a year ago

There is a debugger included in MS Visual Studio but it's not showing me any problem. I will try another debugger.

soulseekah Over a year ago

@Ordo look at the auto and local variables in a step by step debugging session in MSVS, you will quickly see what is wrong.

John Bode Over a year ago

@Soulseekah: the OP's code uses a variable length array, which was introduced with C99 and requires a C99 compiler to translate. C89 requires array lengths to be specified with a constant expression (i.e., something that can be evaluated at compile time).

|

Collectives™ on Stack Overflow

Using functions and arrays

1 Answer 1

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related