Python variable assigning to another variable error

Question

So I am making a program to print the max element of a list,

arr=[1,2,41,6,9,8,5]
c=0
def findmax(x,y):
    if(x>y):
        global c=x
    else:
        global c=y

for x in range(0,len(arr)):
    findmax(c,arr[x])

print(c)

When I try to run the program, it says error: invald syntax line 5 global c=x pointing to the = sign How do I fix it?

You can not write global x = y, you can only write global x and then later x = y. — willeM_ Van Onsem
– willeM_ Van Onsem, Commented Oct 25, 2017 at 19:57
why not simply do: max(arr) ? you should declare a global in the beginning of the function and then you can use it later on. Plenty of examples over the web. — Nir Alfasi
– Nir Alfasi, Commented Oct 25, 2017 at 19:57
Except for that, using a global us usually a huge antipattern. If you see it, you should definitely put some effort in rethinking your code. — willeM_ Van Onsem
– willeM_ Van Onsem, Commented Oct 25, 2017 at 19:58

yash · Accepted Answer · 2017-10-25 20:01:57Z

2

Before using a global variable, you have to declare that the variable is global

arr=[1,2,41,6,9,8,5]
c=0
def findmax(x,y):
    if(x>y):
        global c
        c=x
    else:
        global c
        c=y

for x in range(0,len(arr)):
    findmax(c,arr[x])

print(c)

or you can just declare a global variable once as

arr=[1,2,41,6,9,8,5]
c=0
def findmax(x,y):
    global c
    if(x>y):
        c=x
    else:
        c=y

for x in range(0,len(arr)):
    findmax(c,arr[x])

print(c)

edited Oct 25, 2017 at 20:01

answered Oct 25, 2017 at 19:58

yash

1,3553 gold badges24 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Nir Alfasi Over a year ago

Why do you declare global c twice?

yash Over a year ago

Because every time it calls a function, only one of the code block will be executed (either if or else).

Nir Alfasi Over a year ago

If you're going to do it anyways (regardless if the if/else is getting executed) why not do it once in the beginning? do you like duplicated code ? if the variable name changes later, now you have to change it in two places instead of one (just an example of why it's bad practice).

yash Over a year ago

True @alfasin. I agree it's a bad practice. that's why I added the modified code snippet after your first comment

Green Falcon · Accepted Answer · 2017-10-25 20:01:44Z

1

The following line is not correct:

global x = y

instead you have to first write

global x

then you are allowed to assign x.

answered Oct 25, 2017 at 20:01

Green Falcon

8363 gold badges18 silver badges51 bronze badges

Collectives™ on Stack Overflow

Python variable assigning to another variable error

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related