Search for an element in a struct array, c programming

Question

I am trying to search for an element in the struct. So the user will enter the id, and it will search the struct to see it if contains that information. When I ran the program, it always returns the last element in the array. I am not sure if I am searching correctly. Here is my code:

typedef struct
{       
    int locationNum;
    char id[15];
    char description[50];
    float latitude;
    float longitude;
} localInfo;


// passing in the locationArray struct and count is the length of the array
void searchLocation(localInfo *locationArray, int count)
{
    char locationID[15];
    printf("\nEnter Location ID to search: ");
    scanf("%s", locationID);
    getchar();

    int i;
    for(i = 0; i < count; i++)
    {
        if(strcmp(locationArray[i].id, locationID))
        {
            printf("Found it!, Here are the informations:\n");
            printf("Location ID: %s\n", locationArray[i].id);
            printf("Location Description: %s\n", locationArray[i].description);
            printf("Location Latitude: %s\n", locationArray[i].latitude);
            printf("Location Longitude: %s\n", locationArray[i].longitude);
        }
        else
        {
            printf("ID is NOT Found\n");
        }
    }
}

strcmp will return 0 if two strings are the same. So your if statement will not hold. Change to if(!(strcmp(locationArray[i].id, locationID)) — Tony Tannous
– Tony Tannous, Commented Oct 10, 2017 at 21:50
if (strcmp(locationArray[i].id, locationID) == 0) (you should also add break; at the end of the if to stop searching if it is found. — David C. Rankin
– David C. Rankin, Commented Oct 10, 2017 at 21:51

Claudio Borges · Accepted Answer · 2017-10-10 23:32:25Z

1

The issue is because strcmp return 0 when it matches:

void searchLocation(localInfo *locationArray, int count)
{
    char locationID[15];
    printf("\nEnter Location ID to search: ");
    scanf("%s", locationID);
    getchar();

    int i;
    for(i = 0; i < count; i++)
    {
        if(strcmp(locationArray[i].id, locationID) == 0)
        {
            printf("Found it!, Here are the informations:\n");
            printf("Location ID: %s\n", locationArray[i].id);
            printf("Location Description: %s\n", locationArray[i].description);
            printf("Location Latitude: %s\n", locationArray[i].latitude);
            printf("Location Longitude: %s\n", locationArray[i].longitude);

            break;
        }
        else
        {
            printf("ID is NOT Found\n");
        }
    }
}

answered Oct 10, 2017 at 23:32

Claudio Borges

1322 silver badges6 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Search for an element in a struct array, c programming

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related