Javascript function not working with an array

Question

i have this function which loops through an array of check boxes checking if the boxes value is equal to something in a text box, i dont know whats wrong.

function checkValue(contain)  {  
        var boxes = document.getElementsByTagName("input");  
    for (var i = 0; i < boxes.length; i++) {  
        if (boxes[i].name == "vote[]") {  
            if (boxes[i].value.indexOf(contain.value) != -1) {  
            boxes[i].checked = true;  
        }  
    }   
}  
}

and this is how i call it

 OnClick="uncheckAll(); checkValue(document.getElementsByName("countrylist"));"

this code is in side a echo in php which is like this echo ' ';

nsdel · Accepted Answer · 2011-01-07 20:54:01Z

2

You cannot nest the same type of quotes in HTML.

OnClick="uncheckAll(); checkValue(document.getElementsByName(\'countrylist\'));"

Simply escape the single quotes as shown as PHP provides an easy escape mechanism.

answered Jan 7, 2011 at 20:54

nsdel

2,2731 gold badge17 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Ryan Harvie Over a year ago

as said, im using php to echo it in single quotation marks so if i were to use single quotation marks my php would error

webbiedave Over a year ago

@Ryan, then escape them with \' php.net/manual/en/language.types.string.php

Peter Perháč · Accepted Answer · 2011-01-07 20:53:42Z

0

the contain argument you're passing is an array not a string. that could be the problem?

answered Jan 7, 2011 at 20:53

Peter Perháč

20.8k23 gold badges129 silver badges153 bronze badges

3 Comments

Ryan Harvie Over a year ago

but the value "contain" is not an array its the word "UK"

Peter Perháč Over a year ago

the argument "contain" is the return value of this call document.getElementsByName("countrylist") getElementsByName returns an array of elements with that name

Peter Perháč Over a year ago

yes, or you should pass document.getElementsByName("countrylist")[0] to the function. either way should help. also, as InsDel suggested, you can't nest javascript double quotes inside html double quotes, so change them for single quotes document.getElementsByName('countrylist')[0]

Christa · Accepted Answer · 2011-01-07 20:57:26Z

0

I think your javascript might be having an issue with the name of your field being vote[].

Does it ever pass the condition:

if (boxes[i].name == "vote[]") {

answered Jan 7, 2011 at 20:57

Christa

4854 silver badges4 bronze badges

1 Comment

Ryan Harvie Over a year ago

yes, i have a function to check all boxes so i modified it to the above results, but yes the check all function works

Chandu · Accepted Answer · 2011-01-07 21:01:54Z

0

1) Update the inlince call to use single quotes:

checkValue(document.getElementsByName('countrylist'))

2) Use document.getElementsByName to make the function little better:

function checkValue(contain)  
{           
    var boxes = document.getElementsByName("vote[]");
    for (var i = 0; i < boxes.length; i++) 
    {     
        boxes[i].checked = (boxes[i].value == contain.value);
    }   
}

answered Jan 7, 2011 at 21:01

Chandu

83.2k19 gold badges136 silver badges136 bronze badges

Collectives™ on Stack Overflow

Javascript function not working with an array

4 Answers 4

2 Comments

3 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

3 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related