AngularJS - Dynamic parameter in $http URL

Question

The URL I use to retreive a JSON for my app has a dynamic parameter (:id ). I'm not too sure how I can work with this, so that it passes the ID the user has chosen. Just need a bit of guidance.

app.factory('bookcategories', ['$http', function($http) {
  return $http.get('http://52.41.65.211:8028/api/v1/categories/:id/books.json')
    .success(function(data) {
        return data;
    })
    .error(function(err) {
        return err;
  });
}]);

Controller

app.controller('BookCategoryController', ['$scope', 'categories', '$routeParams',  function($scope, categories, $routeParams) {
    categories.success(function(data) {
    $scope.detail = data.categories[$routeParams.bookId];
    $scope.currentCategoryIndex = parseInt($routeParams.categoryId);

        $scope.myCategoriesDetails = $scope.category;
    });
}]);

app.js

...
  .when('/categories/:categoryId', {
    controller: 'BookCategoryController',
    templateUrl: 'views/booksincategory.html'
})
...

HTML

<h3 class="title">{{book.title}}</h3>

A factory is supposed to return an object, which has methods that the users of the service can call. Your factory directly calls $http and returns a promise. — JB Nizet
– JB Nizet, Commented Sep 14, 2017 at 8:46
bookcategories should be a service. Btw. bookcategories is never used in your codes? — lin
– lin, Commented Sep 14, 2017 at 9:09
Use1937021, I see you don't like to mark "right answers". Please check all your questions and mark right answers. Thanks — lin
– lin, Commented Sep 14, 2017 at 9:16
Thanks m8, please check your other questions and mark right answers please. — lin
– lin, Commented Sep 14, 2017 at 9:40

lin · Accepted Answer · 2017-09-14 18:08:27Z

1

You could achieve this with a little service like the following code example. A factory is a wrong choice here.

app.service('bookCategories', ['$http', function($http) {
  this.get = function (id) {
      return $http.get('http://52.41.65.211:8028/api/v1/categories/'+ id + '/books.json')
        .success(function(data) {
          return data;
        })
        .error(function(err) {
          return err;
        });
  };
}]);

And than use it like:

app.controller('MyCtrl', function(bookCategories) {
  bookCategories.get(1).then(function (result) {
    console.log(result);
  });
});

edited Sep 14, 2017 at 18:08

answered Sep 14, 2017 at 9:13

lin

18.5k4 gold badges66 silver badges88 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

JB Nizet Over a year ago

A factory is a wrong choice here and yet the code you posted is actually a factory disguised as a service. A real service would initialize this, and wouldn't return anything.

Collectives™ on Stack Overflow

AngularJS - Dynamic parameter in $http URL

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related