Value not being set by javascript function

Question

I have a function that should detect which item is selected in dropdown list then change the form, this could be hiding form fields or assigning a value to a field. The hiding/showing of fields is working as it should however the value of the field does not update and is staying blank.

if (document.getElementById('service16').value == '4989') {
  $('#valuediv16').show();
  $('#namediv16').hide();
  $('#qtydiv16').hide();
  $('#cbdiv16').hide();    
} else if (document.getElementById('service16').value == '4946') {
  $('#cbdiv16').hide();
  $('#valuediv16').show();
  $('#value').prop("disabled", false);
  $('#namediv16').hide();
  $('#qtydiv16').show();
  $('#esetdiv16').hide();
  document.getElementById('value').value = "11.70";
} else if (document.getElementById('service16').value == '4987') {
  $('#cbdiv16').hide();
  $('#valuediv16').show();
  $('#value').prop("disabled", false);
  $('#namediv16').hide();
  $('#qtydiv16').show();
  $('#esetdiv16').hide();
  document.getElementById('value').value = "3.80";
} else if (document.getElementById('service16').value == '4988') {
  $('#cbdiv16').hide();
  $('#valuediv16').show();
  $('#value').prop("disabled", false);
  $('#namediv16').hide();
  $('#qtydiv16').show();
  $('#esetdiv16').hide();
  document.getElementById('value').value = "9.40";
}

Just FYI, it'd be worth researching the DRY principle to improve your code — Rory McCrossan
– Rory McCrossan, Commented Sep 7, 2017 at 12:50

Verthosa · Accepted Answer · 2017-09-07 12:48:15Z

2

first of all, if you are using JQuery, you should always use it and not switch between plain javascript and JQuery.

The line

document.getElementById('service16').value == '4988'

can be written in JQuery like

$("#service16").val() == '4988'

That said, converting

document.getElementById('value').value = "9.40";

to

$("#value").val('9.40')

Are you sure you are using 'value' as an id? Have you tried using another id? It's a string, but it doesn't look like a great practise to use value as an id name.

answered Sep 7, 2017 at 12:48

Verthosa

1,6881 gold badge16 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

ProEvilz Over a year ago

Jquery is Javascript. To say you shouldn't switch is silly.

Verthosa Over a year ago

ProEvilz, yes of course, but imo when you choose JQuery, stick with it, even if it's only for readability / colleague consensus

Patrick Goode · Accepted Answer · 2017-09-07 12:58:19Z

0

 $('#service16 option:selected').html();

or

 $('#service16 option:selected').val();

answered Sep 7, 2017 at 12:58

Patrick Goode

1,4725 gold badges20 silver badges37 bronze badges

Collectives™ on Stack Overflow

Value not being set by javascript function

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related