Making a custom Exception with parameters

Question

I'm trying to make a custom exception, the only thing that this custom Exception has to do is to change the message of the exception but have all the attributes of the original exception.

The idea is that the message will change based on the parameter I send.

public class ServiceDireccionException : Exception
{

    public ServiceDireccionException(string type) : base(GetMessage(type)) { }

    public enum TypeOfService
    {
        Provincia,
        Municipio,
        Localidad
    }

    private static string GetMessage(string type)
    {
        string message = "";

        switch (type)
        {
            case nameof(TypeOfService.Provincia):
                message = ("Sucedio un error al buscar la/s" + TypeOfService.Provincia.ToString() + "/s");
                break;

            case nameof(TypeOfService.Municipio):
                message = ("Sucedio un error al buscar lo/s" + TypeOfService.Municipio.ToString() + "/s");
                break;

            case nameof(TypeOfService.Localidad):
                message = ("Sucedio un error al buscar la/s" + TypeOfService.Localidad.ToString() + "/es");
                break;
        }

        return message;
    }

}

When I want to use it in a try catch I can't pass the argument:

    catch (ServiceDireccionException ex) //<-- It does not prompt me to pass a string.
    {
        throw ex;
    }

a catch is not the place where the exception is instantiated... and BTW you should pass the enum to the constructor instead of a string. — Lucas Trzesniewski
– Lucas Trzesniewski, Commented Sep 6, 2017 at 14:04
Instead the throw-statement is the correct place where it is instantiated. So investigate on where the exception is thrown, not where you handle it. — MakePeaceGreatAgain
– MakePeaceGreatAgain, Commented Sep 6, 2017 at 14:05

Tom Schardt · Accepted Answer · 2017-09-07 18:45:17Z

5

you would use it like

throw new ServiceDireccionException(TypeOfService.Provincia);

but therefore you need to change the constructor parameter type to

public ServiceDireccionException(TypeOfService type) : base(GetMessage(type)) { }

To keep information it should contain inner exception

catch (ServiceDireccionException ex) 
{
    throw new ServiceDireccionException(ex, TypeOfService.Provincia);
}

therefore the constructor will be something like

public ServiceDireccionException(Exception innerException, TypeOfService type) 
    : base(GetMessage(type), innerException) 
{
}

to get the message use

private static string GetMessage(TypeOfService type)
{
    switch (type)
    {
        case TypeOfService.Provincia:
            return $"Sucedio un error al buscar la/s {type}/s";

        case TypeOfService.Municipio:
            return $"Sucedio un error al buscar lo/s {type}/s";

        case TypeOfService.Localidad:
            return $"Sucedio un error al buscar la/s {type}/es";
    }

    return $"Unknown TypeOfService: {type}";
}

edited Sep 7, 2017 at 18:45

answered Sep 6, 2017 at 14:08

Tom Schardt

4981 gold badge8 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Tom Schardt Over a year ago

@user3442470: try the updated version of GetMessage().

Collectives™ on Stack Overflow

Making a custom Exception with parameters

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related