ASP.NET MVC Create Method

Question

I have the following Create Method in my HomeController:

[AcceptVerbs(HttpVerbs.Post)]
        public ActionResult Create([Bind(Exclude = "Id")]Article articleToCreate)
        {
            if (!ModelState.IsValid)
                return View();

            try
            {
                _db.AddToArticleSet(articleToCreate);
                _db.SaveChanges();

                return RedirectToAction("Index");
            }
            catch
            {
                return View();
            }
        }

And here is the view:

<% using (Html.BeginForm()) {%>

        <fieldset>
            <legend>Fields</legend>
            <p>
                <label for="headline">Headline</label>
                <%= Html.TextBox("headline") %>
            </p>
            <p>
                <label for="story">Story</label>
                <%= Html.TextArea("story") %>
            </p>
            <p>
                <label for="image">Image URL</label>
                <%= Html.TextBox("image") %>
            </p>
            <p>
                <input type="submit" value="Create News Story" />
            </p>
        </fieldset>

    <% } %>

However when I hit submit I'm just returned to the form (with the fields still filled in) and the new story isn't created. Any ideas why? Thanks.

Edit: I get the following error in the InnerException {"SqlDateTime overflow. Must be between 1/1/1753 12:00:00 AM and 12/31/9999 11:59:59 PM."}

Justin Niessner · Accepted Answer · 2011-01-05 16:49:04Z

3

There are only two situations that would cause that to happen. Either your ModelState is invalid:

if(!ModelState.IsValid)
    return View();

Or there are Exceptions being thrown when trying to write to the db:

catch { return View(); }

Since you have no validation messages in your View, there's no visual feedback to whether or not something is invalid. There's also no way for me to tell if there are database issues.

I would suggest setting a breakpoint at the beginning of the Action method and stepping through. That will tell you exactly what the issue is.

answered Jan 5, 2011 at 16:49

Justin Niessner

246k40 gold badges416 silver badges546 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Cameron Over a year ago

It happens at the catch part and says an error occurred while updating the entries. See the innerexception for details.

Cameron Over a year ago

I get this error: {"SqlDateTime overflow. Must be between 1/1/1753 12:00:00 AM and 12/31/9999 11:59:59 PM."}

Justin Niessner Over a year ago

@Cameron - Considering you don't have a date selection field in your View and you're not setting one in you controller, I'd say that is your problem.

Cameron Over a year ago

Well I just want to set the posted value to the current date. How do I do that? Thanks.

Justin Niessner Over a year ago

articleToCreate.WhateverThePropertyIs = DateTime.Now;

Kevin LaBranche · Accepted Answer · 2011-01-05 16:51:52Z

0

Under both cases where you return the view you aren't returning in any way what went wrong. So either your Model State is Invalid OR the Save to the DB failed.....

answered Jan 5, 2011 at 16:51

Kevin LaBranche

21.1k5 gold badges55 silver badges77 bronze badges

Comments

3Dave · Accepted Answer · 2011-01-05 16:53:38Z

0

Since you're sinking any exception that happens while creating the article, you'll never get an error that happens during this phase. (See Elmah for a very, very easy way to log all of your errors)

Have you tried setting a breakpoint in the method and seeing what's really happening? I'd bet that either your model state is invalid or you're getting an exception.

Slightly related - none of your return methods:

return View();

return RedirectToAction("Index");

// and the last one
return View();

pass any model data to the view, so you won't see any of your field values in the case that there is a validation error.

answered Jan 5, 2011 at 16:53

3Dave

29.2k18 gold badges91 silver badges155 bronze badges

Collectives™ on Stack Overflow

ASP.NET MVC Create Method

3 Answers 3

5 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

5 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related