Loop task through all input files python

Question

I am trying to count all the As and Bs and Cs in all the .txt files I supply and make a .csv file that lists the counts one by one of all those letters.

The code here does all I want but only with the last file I supply instead of all of them.

What am I doing wrong?

import glob
import csv

#This will print out all files loaded in  the same directory and print them out
for filename in glob.glob('*.txt*'):
    print(filename)

#A B and C
substringA = "A"
Head1 = (open(filename, 'r').read().count(substringA))
substringB = "B"
Head2 = (open(filename, 'r').read().count(substringB))
substringC = "C"
Head3 = (open(filename, 'r').read().count(substringC))
header = ("File", "A Counts" ,"B Counts" ,"C Counts")
analyzed = (filename, Head1, Head2, Head3)

#This will write a file named Analyzed.csv
with open('Analyzed.csv', 'w', newline='') as csvfile:
    writer = csv.writer(csvfile)
    writer.writerow(header)
    writer.writerow(analyzed)

Is the code which is counting A B and C in the for loop or outside of it? — Professor_Joykill
– Professor_Joykill, Commented Aug 16, 2017 at 15:29
just move your counting code 4 spaces to the right for it to be inside for loop :) — 9dogs
– 9dogs, Commented Aug 16, 2017 at 15:33
I think that is exactly my issue. I don't know how I can loop my code that is counting through all files. — Scarlett
– Scarlett, Commented Aug 16, 2017 at 15:35

M3RS · Accepted Answer · 2017-08-16 15:44:45Z

2

Indentation was missing and open Analyzed.csv in append mode a:

import glob
import csv

#This will print out all files loaded in  the same directory and print them out
for filename in glob.glob('*.txt*'):
    print(filename)

    #A B and C
    substringA = "A"
    Head1 = (open(filename, 'r').read().count(substringA))
    substringB = "B"
    Head2 = (open(filename, 'r').read().count(substringB))
    substringC = "C"
    Head3 = (open(filename, 'r').read().count(substringC))
    header = ("File", "A Counts" ,"B Counts" ,"C Counts")
    analyzed = (filename, Head1, Head2, Head3)

    #This will write a file named Analyzed.csv
    with open('Analyzed.csv', 'a') as csvfile:
        writer = csv.writer(csvfile)
        writer.writerow(header)
        writer.writerow(analyzed)

EDIT: removed unsupported newline="" parameter

edited Aug 16, 2017 at 15:44

answered Aug 16, 2017 at 15:36

M3RS

7,6706 gold badges42 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

bendl Over a year ago

Will overwrite Analyzed.txt

Malexandre Over a year ago

You must open the output file before the for or open it in append mode (but it will not erase previous run data).

M3RS Over a year ago

I changed it to opening in append mode a

bendl · Accepted Answer · 2017-08-16 16:00:30Z

1

There's another small change you need to make: you need to open as append, not write, as well as indent. Note that when you open as append, you won't overwrite anything that was there before, so I added the portion at the top to delete anything already in the csv.

import glob
import csv


#This will delete anything in Analzyed.csv if it exists and replace it with the header
with open('Analyzed.csv','w') as csvfile:
    writer = csv.writer(csvfile)
    header = ("File", "A Counts" ,"B Counts" ,"C Counts")
    writer.writerow(header)

for filename in glob.glob('*.txt*'):
    print(filename)

    #A B and C
    substringA = "A"
    Head1 = (open(filename, 'r').read().count(substringA))
    substringB = "B"
    Head2 = (open(filename, 'r').read().count(substringB))
    substringC = "C"
    Head3 = (open(filename, 'r').read().count(substringC))
    header = ("File", "A Counts" ,"B Counts" ,"C Counts")
    analyzed = (filename, Head1, Head2, Head3)

    #This will write a file named Analyzed.csv
    with open('Analyzed.csv', 'a', newline='') as csvfile:
        writer = csv.writer(csvfile)
        writer.writerow(analyzed)

Above is my solution keeping as much of your code untouched as possible. Ideally, though, you would only open the file once, at the beginning of the file. This is how you would do that:

import glob
import csv


with open('Analyzed.csv','w') as csvfile:
    writer = csv.writer(csvfile)
    header = ("File", "A Counts" ,"B Counts" ,"C Counts")
    writer.writerow(header)

    for filename in glob.glob('*.txt*'):
        print(filename)

        #A B and C
        substringA = "A"
        Head1 = (open(filename, 'r').read().count(substringA))
        substringB = "B"
        Head2 = (open(filename, 'r').read().count(substringB))
        substringC = "C"
        Head3 = (open(filename, 'r').read().count(substringC))
        analyzed = (filename, Head1, Head2, Head3)

        writer.writerow(analyzed)

edited Aug 16, 2017 at 16:00

answered Aug 16, 2017 at 15:40

bendl

1,6302 gold badges19 silver badges45 bronze badges

2 Comments

Scarlett Over a year ago

Thank you so much. That works well. How to I avoid that it writes the head of the table multiple times. writer.writerow(header) do this just the very first time.

bendl Over a year ago

Whoops, I didn't notice that part, I'll add a fix

Ajax1234 · Accepted Answer · 2017-08-16 15:39:06Z

0

You can try this:

from itertools import chain
from collections import Counter
for filename in glob.glob('*.txt*'):
     data = chain.from_iterable([list(i.strip("\n")) for i in open(filename)])

     the_count = Counter(data)
     with open('Analyzed.csv', 'w', newline='') as csvfile:
         writer = csv.writer(csvfile)
         writer.writerow(filename)
         writer.writerow("A count: {}".format(the_count["A"]))
         writer.writerow("B count: {}".format(the_count["B"]))
         writer.writerow("C count: {}".format(the_count["C"]))

answered Aug 16, 2017 at 15:39

Ajax1234

71.7k9 gold badges67 silver badges110 bronze badges

Collectives™ on Stack Overflow

Loop task through all input files python

3 Answers 3

3 Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related