Python - while input doesn't work

Question

Why doesn't this work? I input windows/meterpreter/reverse_tcp and it returns the error...again

def shellcode():
    os.system("clear")
    print style
    print green + "  [+]Your Choose 4 | C Type Format - ShellCode Generate"
    print style
    print payload_types
    print ' '
    payload_choose = raw_input(time + white + "Choose Payload > ")
    while (payload_choose != "windows/meterpreter/reverse_tcp" or "linux/x86/meterpreter/reverse_tcp"):
        print "[-]error"
        payload_choose = raw_input(time + white + "Choose Payload > ")
    print "ok"

user94559 · Accepted Answer · 2017-08-11 18:37:26Z

4

This line:

while (payload_choose != "windows/meterpreter/reverse_tcp" or "linux/x86/meterpreter/reverse_tcp"):

probably doesn't do what you want. I think you probably meant this?

while payload_choose != "windows/meterpreter/reverse_tcp" and payload_choose != "linux/x86/meterpreter/reverse_tcp":

Further explanation

This expression:

a or b

means "a is true or b is true".

This expression:

foo != 'hello' or 'goodbye'

means "(foo != 'hello') is true or 'goodbye' is true". In Python, a non-empty string is considered "truthy", so your original while loop condition is always true.

edited Aug 11, 2017 at 18:37

answered Aug 11, 2017 at 18:34

user94559

60.3k6 gold badges108 silver badges107 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Inj3ct0r Over a year ago

one of this.. windows/meterpreter/reverse_tcp or linux/x86/meterpreter/reverse_tcp if i put and must to choose linux/x86/meterpreter/reverse_tcp and windows/meterpreter/reverse_tcp :/

user94559 Over a year ago

@Inj3ct0r What? I don't understand what you're saying.

user94559 Over a year ago

So fix your indentation? Make sure you didn't mix tabs and spaces.

Collectives™ on Stack Overflow

Python - while input doesn't work

1 Answer 1

Further explanation

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Further explanation

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related