error when adding data in my database

Question

I am trying to configure a simple SQLiteOpenHelper, and getting an error while executing. android.database.sqlite.SQLiteException: table people_table has no column named Minutes (code 1): , while compiling: INSERT INTO people_table(Minutes,Hour) VALUES (?,?) I canot figure out what is the problem?

  package radiofm.arabel;

import android.content.ContentValues;
import android.content.Context;
import android.database.Cursor;
import android.database.sqlite.SQLiteDatabase;
import android.database.sqlite.SQLiteOpenHelper;
import android.util.Log;


public class DatabaseHelper extends SQLiteOpenHelper {

    private static final String TAG = "DatabaseHelper";

    private static final String TABLE_NAME = "people_table";
    private static final String COL1 = "ID";
    private static final String COL2 = "Hour";
    private static final String COL3 = "Minutes";



    public DatabaseHelper(Context context) {
        super(context, TABLE_NAME, null, 1);
    }

    @Override
    public void onCreate(SQLiteDatabase db) {

        String createTable = "CREATE TABLE " + TABLE_NAME + " (" +

                COL1 + "ID INTEGER PRIMARY KEY AUTOINCREMENT," +

                COL2 + "TEXT," +

                COL3 + "TEXT "  +

                ");";

        db.execSQL(createTable);
    }

    @Override
    public void onUpgrade(SQLiteDatabase db, int i, int i1) {
        db.execSQL("DROP IF TABLE EXISTS " + TABLE_NAME);
        onCreate(db);
    }

    public boolean addData(String item1,String item2) {
        SQLiteDatabase db = this.getWritableDatabase();
        ContentValues contentValues = new ContentValues();
        contentValues.put(COL2, item1);
        contentValues.put(COL3, item2);

        Log.d(TAG, "addData: Adding " + item1 + " to " + TABLE_NAME);


        long result = db.insert(TABLE_NAME, null, contentValues);

        //if date as inserted incorrectly it will return -1
        if (result == -1) {
            return false;
        } else {
            return true;
        }
    }


}

Glorfindel · Accepted Answer · 2023-02-26 09:02:26Z

1

You forgot the space when creating the table. Your column is named MinutesTEXT right now.

It is not an error in itself because you do not have to specify the column type in SQLite.

Reference

To fix it, make sure you delete the current database and replace your Create table query with this.

String createTable = "CREATE TABLE " + TABLE_NAME + " (" +

                COL1 + " INTEGER PRIMARY KEY AUTOINCREMENT," +

                COL2 + " TEXT," +

                COL3 + " TEXT "  +

                ");";

edited Feb 26, 2023 at 9:02

Glorfindel

22.8k13 gold badges97 silver badges124 bronze badges

answered Jul 31, 2017 at 15:36

litelite

2,8464 gold badges26 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

mohammad alsaleh Over a year ago

what do u mean ?

litelite Over a year ago

What do i mean by what?

mohammad alsaleh Over a year ago

where did i forget the space ?

litelite Over a year ago

Between the column name and the type when you concatenate.

litelite Over a year ago

Are you sure you deleted the database. In android, if the database is already present, onCreate will not be called and so your old name will still be there. To do it you could force an update by changing the version number

Victor Hugo Montes · Accepted Answer · 2017-07-31 16:04:06Z

0

Your onCreate seems to be missing spaces on your SQL column definition. Also, your id columns must to be defined as _id.

Try this.

 private static final String COL1 = "_id";

And

@Override
    public void onCreate(SQLiteDatabase db) {

        String createTable = "CREATE TABLE " + TABLE_NAME + " (" +

                COL1 + " INTEGER PRIMARY KEY AUTOINCREMENT, " +

                COL2 + " TEXT, " +

                COL3 + " TEXT "  +

                ");";

        db.execSQL(createTable);
    }

edited Jul 31, 2017 at 16:04

answered Jul 31, 2017 at 15:37

Victor Hugo Montes

1,3331 gold badge18 silver badges31 bronze badges

4 Comments

Victor Hugo Montes Over a year ago

Can you debug and paste createTable value here, please?

mohammad alsaleh Over a year ago

CREATE TABLE people_table (ID ID INTEGER PRIMARY KEY AUTOINCREMENT,Hour TEXT,Minutes TEXT );

Victor Hugo Montes Over a year ago

@mohammadalsaleh see my editing and let me know if it solves.

Victor Hugo Montes Over a year ago

ID ID INTEGER... seems to be wrong. I edited the answered. See if it works

Collectives™ on Stack Overflow

error when adding data in my database

2 Answers 2

5 Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related