MVC C# "not all code paths return a value"

Question

I am having a problem with my solution. I am trying to create an MVC application wherein the view has a textbox for a string, a dropdown list for sorting type(e.g bubble sort,quick sort) and a button to sort the string.

here is my code in controller:

[HttpPost]
    public ActionResult total(string value1, String calci)
    {
        char[] total;
        switch (calci)
        {
            case "bubbleSort":
                total = value1.ToCharArray();
                char temp;
                for (int write = 0; write < total.Length; write++)
                    for (int sor = 0; sor < total.Length - 1; sor++)
                        if (total[sor] > total[sor + 1])
                        {
                            temp = total[sor + 1];
                            total[sor + 1] = total[sor];
                            total[sor] = temp;
                        }
                return Content("Result " + total);

        }
    }

it keeps giving me an error of "not all code paths return a value" I really need to run this program, also ignore the "total" from my actionresult because my the original solution of this project is my calculator project.Thankyou!

could be wrong but I think you need a break; at the end of your case. Also a default case should be included. — Capn Jack
– Capn Jack, Commented Jul 24, 2017 at 17:59
@CapnJack: No; that isn't reachable because of the return. — SLaks
– SLaks, Commented Jul 24, 2017 at 17:59
Add the default case inside the switch, or a return at the end of your method. — cYOUNES
– cYOUNES, Commented Jul 24, 2017 at 18:00

kots · Accepted Answer · 2017-07-24 18:03:03Z

2

You will need a default case such as this:

        switch (calci)
        {
            case "bubbleSort":
                total = value1.ToCharArray();
                char temp;
                for (int write = 0; write < total.Length; write++)
                for (int sor = 0; sor < total.Length - 1; sor++)
                    if (total[sor] > total[sor + 1])
                    {
                        temp = total[sor + 1];
                        total[sor + 1] = total[sor];
                        total[sor] = temp;
                    }
                return Content("Result " + total);
            default:
                return Content("Result 0");                    
        }

answered Jul 24, 2017 at 18:03

kots

4652 silver badges7 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Capn Jack · Accepted Answer · 2017-07-24 18:06:22Z

2

Your issue is that you only have a return value in your switch statement. If the case is "bubbleSort" the there isn't anything to return! Whenever you have a method with a return type other than void, you need to ensure all possible routes have a return value of the type specified when creating your class.

You can resolve this by adding a default case statement that returns a result as well. Try adding this after your first case:

default:
    return Content(@"Unhandled 'calci' parameter: " + calci);

edited Jul 24, 2017 at 18:06

answered Jul 24, 2017 at 18:00

Capn Jack

1,25113 silver badges30 bronze badges

1 Comment

AaronLS Over a year ago

See default: here: learn.microsoft.com/en-us/dotnet/csharp/language-reference/…

SLaks · Accepted Answer · 2017-07-24 17:59:27Z

1

As the error is trying to tell you, you need to make sure that your function always returns a value.

Even if calci is not "bubbleSort".

answered Jul 24, 2017 at 17:59

SLaks

891k182 gold badges1.9k silver badges2k bronze badges

Collectives™ on Stack Overflow

MVC C# "not all code paths return a value"

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related