Escape string in jQuery while passing a variable as a parameter

Question

I am trying to pass a variable inside a JavaScript function. The problem I'm failing to figure out how to escape string to send that variable inside a double quote. There are tons of answers on this but I couldn't use them correctly.

for (var k = 0; k < districts[division].length; k++) {
    $('#district_list').append('<li class="byebooklist"><a href="javascript:getUniversity(' + districts[division][k] + ');">' + districts[division][k] + '</a></li>');
}

How to pass the parameter to the getUniversity() function inside a double quote?

hsz · Accepted Answer · 2017-07-20 11:46:45Z

4

Just try with escaped quotes:

$('#district_list').append(
  '<li class="byebooklist"><a href="javascript:getUniversity(\''+districts[division][k]+'\');">'+districts[division][k]+'</a></li>'
);
//                                                           ^^                          ^^

edited Jul 20, 2017 at 11:46

answered Jul 20, 2017 at 9:30

hsz

153k63 gold badges268 silver badges320 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Rory McCrossan · Accepted Answer · 2017-07-20 09:33:43Z

To fix this you need to wrap the value in the function argument in quotes, but you'll need to escape them, using \':

for (var k = 0; k < districts[division].length; k++) {
  $('#district_list').append('<li class="byebooklist"><a href="javascript:getUniversity(\'' + districts[division][k] + '\');">' + districts[division][k] + '</a></li>');
}

However, you can both avoid the problem and improve the logic by not putting any JS in the href at all and instead using an unobtrusive event handler. As you've tagged the question with jQuery, here's how you can do that:

var html = districts[division].map(function(div) {
  return '<li class="byebooklist"><a href="#" data-division="' + div + '">' + div + '</a></li>';
}).join('');
$('#district_list').append(html);

$(document).on('click', '.byebooklist a', function(e) {
  e.preventDefault();
  getUniversity($(this).data('division'));
});

Collectives™ on Stack Overflow

Escape string in jQuery while passing a variable as a parameter

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related