insert Multiple new record in databse asp.net mvc [duplicate]

Question

I have a pretty simple ActionResult function that is called from my view and it receives a number from it, I want to add this much new rows in my database equals to that number and the only column I fill in is the id of the formation it is related to, here is my code as of now

public ActionResult AddInfo(int? idfrm,int? NumberToAdd)
    {
        using (InscriptionFormationEntities dbm = new InscriptionFormationEntities())
        {
            for(int i=0;i<NumberToAdd;i++)
            {
                INSC_MoreInfo NewEntry= new INSC_MoreInfo ();
                NewEntry.idformation = idfrm;
                dbm.INSC_MoreInfo .Add(info);
            }
            dbm.SaveChanges();
        }
            return View(idfrm);
    }

The code above works perfectly but I was wondering if there was a way to arrive at the same result without relying on a for loop since it could be slow if for example the number of new entry to make is really big ( it could very well be in this case)

**Note:**My project is made in asp.net mvc 5,my code is database first and I use Entity framework to connect with it

@CodingYoshi Because If I have to add 1000000 new entry my loop is gonna create a new instance plus add it each time — Missing_DLL
– Missing_DLL, Commented Jul 14, 2017 at 18:34
You can replace the for loop with AddRange call, but I don't think it's relevant, since the slowest part is inserting the records to the database (when you call SaveChanges) since EF does not support bulk insert. — Ivan Stoev
– Ivan Stoev, Commented Jul 14, 2017 at 18:35
@IvanStoev yeah I tried to have a bulk insert but it seems that entity-framework dosen't support it natively — Missing_DLL
– Missing_DLL, Commented Jul 14, 2017 at 18:36

Tim Copenhaver · Accepted Answer · 2017-07-14 18:34:19Z

3

The short answer is no - you can't eliminate iterating to create X number of items. You could rewrite your code to technically eliminate the for loop, but behind the scenes you still have to use an iterator of some sort to create the objects.

As long as you are only calling SaveChanges() once outside the loop, you shouldn't see any significant performance issues with this approach. Even though you use a for loop, this ultimately results in one SQL Insert statement which will create all records in a single trip to the database (technically may be 2 trips to get versions and things, but one for the query).

answered Jul 14, 2017 at 18:34

Tim Copenhaver

3,30215 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Missing_DLL Over a year ago

Ok thanks for the info, so this is the best way to do it I guess then ?

Tim Copenhaver Over a year ago

Yes, basically what you have is the best way

Collectives™ on Stack Overflow

insert Multiple new record in databse asp.net mvc [duplicate]

1 Answer 1

2 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Linked

Related