Simple Vuejs Validation code not working as expected?

Question

I want to post some js objects to backend only if all items are numbers , here is the code :

  var MyApp = new Vue({

        el: '#my_element',
        data: {
            errors: [],
            votes: []
        },

        methods: {
           send_votes: function(){ 
             if(this.validate_votes(this.votes) === true){ 
                 return this.$http.post('/vote', this.votes).then(
                     function (response) {
                          // success message
                     },
                     function (error) {
                          // error message
                      }
                 )
              },
            }

        },

        validate_votes : function (votes) {

                var all_votes_are_number = true;
                $.each(votes, function (item) {
                    if(isNaN(item)){
                        all_votes_are_number = false;
                        MyApp.errors.push('one of votes is not a number');
                    }
                })

                return all_votes_are_number;
         }

   }

But My validation to check if one of votes is not a number, does not work and code continue posting and saving data in db! what am I doing wrong ?

Also I want to add more validation: all votes should be unique.

Are you sure you have checked the documentation for $.each? First parameter of the callback will be the index, not the item itself. — Mat J
– Mat J, Commented Jul 5, 2017 at 11:35

aprouja1 · Accepted Answer · 2017-07-05 11:41:57Z

1

The issue is your validate_votes function. When using the $.each function, the first argument is the index of the item, and the second argument is the item itself. So if votes was an array equal to ['A','B','C'] you would be checking against 0,1,2. Try the below instead:

validate_votes : function (votes) {

                var all_votes_are_number = true;
                $.each(votes, function (item, el) {
                    if(isNaN(el)){
                        all_votes_are_number = false;
                        MyApp.errors.push('one of votes is not a number');
                    }
                });

                return all_votes_are_number;
         }

answered Jul 5, 2017 at 11:41

aprouja1

1,82011 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ahmad Mobaraki Over a year ago

thank you, I get it, now what about Also I want to add more validation: all votes should be unique.

Collectives™ on Stack Overflow

Simple Vuejs Validation code not working as expected?

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related