MySQL Database Insert

Question

I have very strange problem. I want to run mysql query as it is shown down below, but it's not working. Connection to database is successful, INSERT query is ok too, because when I run it directly in phpmyadmin Console it works, but it's not working here in PHP code.

Could you tell me what I'm missing?

$servername = "localhost";
$username = "admin";
$password = "admin123";
$dbname = "database1";

$conn = mysqli_connect($servername, $username, $password, $dbname);

if (!$conn) {
    die("Connection failed: " . mysqli_connect_error());
}

$sql = "INSERT INTO last_visit (ip, lastvisit) VALUES ('123', '123')";

You're already using an API that supports prepared statements with bounded variable input, you should utilize parameterized queries with placeholders (prepared statements) to protect your database against SQL-injection! Get started with mysqli::prepare() and mysqli_stmt::bind_param(). Even though these values currently are static - they're most likely to change later on, I assume? — Qirel
– Qirel, Commented Jul 4, 2017 at 20:35

Alex Caron · Accepted Answer · 2017-07-04 20:31:19Z

2

You need to run your $sql, because now your $sql is only a string, it does nothing.

Add this :

if ($conn->query($sql) === TRUE) {
    echo "New record created successfully";
} else {
    echo "Error: " . $sql . "<br>" . $conn->error;
}

answered Jul 4, 2017 at 20:31

Alex Caron

3503 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

tadman Over a year ago

Do try and avoid things like === TRUE, it sets up bad habits. In this case if ($conn->query(...)) is sufficient.

Collectives™ on Stack Overflow

MySQL Database Insert

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related