If for loop returns null javascript

Question

I have a loop with inner if statements as follows

var html = "";
var i;
for (i = 0; i < products.length; i++) 
{
  if(products[i].attrs.product_type == type) 
  {
   html += '<p>hello world</p>';      
  }
}

I'd really like to be able to say if no results are returned from for loop, say "Sorry, no results were found" etc… I've tried the following…

for (i = 0; i < products.length; i++) 
{
  if(products[i].attrs.product_type == type) 
  {
   html += '<p>hello world</p>' +i;      
  }
}

But that just puts the object number next to the returned result…

Any help would be great as I'm sure this is very easy

Thanks

at a high level, what you should do is set some variable outside the loop equal to false/zero, then within the loop set it to true/1 and do a check on that variable after the loop is done. If it's still equal to false/zero, you'll know that nothing met the loop conditions. — user2366842
– user2366842, Commented Jul 3, 2017 at 16:15
So if the length is zero than output that message..... What does i have to do with no results? — epascarello
– epascarello, Commented Jul 3, 2017 at 16:16

shotor · Accepted Answer · 2017-07-03 16:26:46Z

2

At the end check whether the html variable is actually filled, if not we didn't find any items and we can use the sorry message:

var html = '';
var i;
for (i = 0; i < products.length; i++) 
{
  if(products[i].attrs.product_type === type) 
  {
   html += '<p>hello world</p>';      
  }
}    

if (html === '') { // or: "if (!html)" if you like that sort of thing
  html = 'Sorry, no results were found'
}

Also notice that I changed the comparison from == to ===. That's because == tries to convert the type. While === does not. Use === to prevent strange errors, usually that's the one you want. For more info on it: Which equals operator (== vs ===) should be used in JavaScript comparisons?

Updated because of comment by @ASDFGerte

edited Jul 3, 2017 at 16:26

answered Jul 3, 2017 at 16:15

shotor

1,07210 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ASDFGerte Over a year ago

Your code appears to be checking whether products has zero length, not whether the loop has any results.

user2366842 · Accepted Answer · 2017-07-03 16:53:14Z

0

Similar to shotor's answer, but a slightly different approach would be as follows:

 var html = "";
 var i;
 var found = false;
 for (i = 0; i < products.length; i++) 
{
     if(products[i].attrs.product_type === type) 
   {
     html += '<p>hello world</p>' +i;
     found = true;      
   }
}    

if (found === false)
  {
    //do stuff here.
  }

edited Jul 3, 2017 at 16:53

answered Jul 3, 2017 at 16:19

user2366842

1,21614 silver badges23 bronze badges

3 Comments

Jonas Wilms Over a year ago

isTrue=false is a funny var name.

maazadeeb Over a year ago

I'd rename isTrue to found. Really confusing when you check isTrue === false. :)

user2366842 Over a year ago

adjusted the name. To me it makes sense, but I suppose it's not the cleanest naming convention in the world :)

sudip · Accepted Answer · 2017-07-03 17:12:57Z

0

var html = "";
var i;
var hasResult = false;
for ( i = 0; i < products.length; i++ ) 
{
  if( products[i].attrs.product_type == type ) 
  {
        html += '<p>hello world</p>';
        hasResult = true;
  }
}

if( !hasResult ){

    html = "No match";
}

answered Jul 3, 2017 at 17:12

sudip

2,9211 gold badge33 silver badges45 bronze badges

Collectives™ on Stack Overflow

If for loop returns null javascript

3 Answers 3

1 Comment

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related