Exception handling fix

Question

My code is printing "Element not found in array" as many times as it takes to get to that number in the array why and how do I fix that.

My Assignment:

Create a Java program with a method that searches an integer array for a specified integer value (see help with starting the method header below). If the array contains the specified integer, the method should return its index in the array. If not, the method should throw an Exception stating "Element not found in array" and end gracefully. Test the method in main with an array that you make and with user input for the "needle".

public static int returnIndex(int[ ] haystack, int needle) {

My code so far:

import java.util.Scanner;
public class Assignment1 {

 public static void main(String[] args) {
     int[] haystack = { 4,5,6,7,12,13,15,16,22,66,99,643 };        
     Scanner sc = new Scanner(System.in);
     System.out.println("Enter a number in the array: ");                
     int needle = sc.nextInt();
     returnIndex(haystack,needle);

   }
 public static int returnIndex(int[] haystack, int needle) {
        for (int n = 0; n < haystack.length; n++) {
            if (haystack[n] == needle) 
                return n;
            else 
                System.out.println("Element not found in array");
        }
        return -1;  
    }
 }

My output:

Enter a number in the array: 
7
Element not found in array
Element not found in array
Element not found in array

or

Enter a number in the array: 
15
Element not found in array
Element not found in array
Element not found in array
Element not found in array
Element not found in array
Element not found in array

HINT: System.out.println("Element not found in array"); doesn't belong inside the loop. — Kevin Anderson
– Kevin Anderson, Commented Jun 26, 2017 at 3:13
Remove the System.out in the else block and check the result after the returnIndex method returns. Handle the result according to your problem description. — andih
– andih, Commented Jun 26, 2017 at 3:13
In your for (int n = 0; n < haystack.length; n++) you print Element not found in array every time condition (haystack[n] == needle) occurs. Try to replace return -1; with it. — Sergey
– Sergey, Commented Jun 26, 2017 at 3:14

Amit · Accepted Answer · 2017-06-26 03:39:21Z

2

You are getting same output multiple times as you are not breaking out of loop.Also if element is not there in array only if you have iterate through the entire array, so move System.out.println("Element not found in array"); outside the for loop. Below is the complete example, have a look.

user below code where i am breaking the loop if element is not found in the array.

public class SOTest {
    public static void main(String[] args) {
        int[] haystack = { 4, 5, 6, 7, 12, 13, 15, 16, 22, 66, 99, 643 };
        Scanner sc = new Scanner(System.in);
        System.out.println("Enter a number in the array: ");
        int needle = sc.nextInt();
        int index = returnIndex(haystack, needle);
        if(index!=-1) // print index only if element is in array.
        System.out.println("Element found at index : " + index);

    }

    public static int returnIndex(int[] haystack, int needle) {
        for (int n = 0; n < haystack.length; n++) {
            if (haystack[n] == needle)
                return n;
        }
        System.out.println("Element not found in array");
        return -1;

    }
}

Edit :- Added runnable code and sample input and output to verify the correctness of program. Also Added the logic to print the index if element is found in the array and -1 index means element is not in array.

Input and output for number :- 120, which is not there in array.

Enter a number in the array: 
120
Element not found in array

for number 5 which is in array, output will be bbelow :-

Enter a number in the array: 
5
Element found at index : 1

edited Jun 26, 2017 at 3:39

answered Jun 26, 2017 at 3:14

Amit

32.5k7 gold badges68 silver badges101 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Kevin Anderson Over a year ago

Try entering 5.

Amit Over a year ago

@KevinAnderson , found it adding the modifying code

michael Over a year ago

Thank you for your feedback but for some reason when I put in a number that is not in the array it prints "...not in array" as well as "... found at index: -1" how do I fix that?

Amit Over a year ago

@michael , just add a condition to print it only if its not -1.

michael Over a year ago

Thank you for the help @AmitK

Isac · Accepted Answer · 2017-06-26 03:15:04Z

You need to put the printline outside the loop:

public static int returnIndex(int[] haystack, int needle) {
        for (int n = 0; n < haystack.length; n++) {
            if (haystack[n] == needle) 
                return n;
        }

        System.out.println("Element not found in array");
        return -1;  
 }

Because if you get the element and return it with the return n; then the lower part won't be executed. Having it in the loop makes it print the not found text for every element that doesn't match the one you are looking for.

A better solution would be to print the element outside of the method, as follows:

public static int returnIndex(int[] haystack, int needle) {
     for (int n = 0; n < haystack.length; n++) {
        if (haystack[n] == needle) 
            return n;
     }
     return -1;  
}

public static void main(String[] args) {
     ...              
     int needle = sc.nextInt();
     if (returnIndex(haystack,needle) == -1){
           System.out.println("Element not found in array");
     }
     else {
           System.out.println("Element found in array");
     }
}

Carlos Ramírez · Accepted Answer · 2017-06-26 03:16:25Z

0

Try putting the System.out above the return -1, this way you won't print "Element not found in array" every time you don't find the number selected.

answered Jun 26, 2017 at 3:16

Carlos Ramírez

1212 gold badges3 silver badges10 bronze badges

Comments

Abhishek · Accepted Answer · 2017-06-26 03:22:39Z

0

Try this

Just Make Small Change In returnIndex function it will work for you

public static int returnIndex(int[] haystack, int needle) {
    for (int n = 0; n < haystack.length; n++) {
        if (haystack[n] == needle) {
            return n;
        } else {
            if(n == haystack.length - 1)
            System.out.println("Element not found in array");
        }
    }
    return -1;
}

answered Jun 26, 2017 at 3:22

Abhishek

3,3983 gold badges17 silver badges36 bronze badges

Collectives™ on Stack Overflow

Exception handling fix

4 Answers 4

5 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

5 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related