Change Script tag value dynamically using javascript

Question

I need to dynamcially change the script tag value based on user choice from drop down, find my code below, it does not return anything

function dynamic()
{
        var sel_size = jQuery("#block_size").val(); 
        var st = sel_size.split("x");
        var site_url = '<?php echo $site_url;?>';
        var path = '<?php echo $this->config->item("path");?>';
        var id = '<?php echo $zone_id;?>';
        var s = document.createElement("script");
            s.type = "text/javascript";
            s.src = url+path+"?id="+id+"width="+st[0]+"height="+st[1];
            s.innerHTML = null;
            alert(s);
}

What is wrong in this, please correct my code, Any help Appreciated...

it will not return anything -- yes because return statement is missing. — 31piy
– 31piy, Commented Jun 22, 2017 at 5:01

FieryCat · Accepted Answer · 2017-06-22 05:01:26Z

1

To apply script you have to run it:

function dynamic()
{
    // ... all other stuff
    var s = document.createElement("script");
    s.type = "text/javascript";
    s.src = url + path + "?id=" + id + "width=" + st[0] + "height=" + st[1];
    // Run your script
    document.body.appendChild(s);
}

answered Jun 22, 2017 at 5:01

FieryCat

1,94922 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mohideen bin Mohammed · Accepted Answer · 2017-06-22 05:04:09Z

0

where is appendChild?

you have created dynamic script tag but you failed to append on body...

append it into body.

document.body.appendChild(s);

answered Jun 22, 2017 at 5:04

Mohideen bin Mohammed

20.4k11 gold badges121 silver badges131 bronze badges

Comments

Pasupathi Thangavel · Accepted Answer · 2017-06-22 05:07:11Z

0

In your function not having url variable. only having site_url variable.So try this one.And you are not put any return value on that function.

function dynamic()
{
    var sel_size = jQuery("#block_size").val(); 
    var st = sel_size.split("x");
    var site_url = '<?php echo $site_url;?>';
    var path = '<?php echo $this->config->item("path");?>';
    var id = '<?php echo $zone_id;?>';
    var s = document.createElement("script");
        s.type = "text/javascript";
        s.src = site_url+path+"?id="+id+"width="+st[0]+"height="+st[1];
        s.innerHTML = null;
        alert(s);
    return something;    // what you need to return in that one.
}

In this code may help you.

answered Jun 22, 2017 at 5:07

Pasupathi Thangavel

9421 gold badge10 silver badges17 bronze badges

Comments

Versha Gupta · Accepted Answer · 2017-06-22 06:29:45Z

0

If url variable not present and have only site_url then use following code. Also added '&' to src.

 function dynamic(){
    var sel_size = jQuery("#block_size").val(); 
    var st = sel_size.split("x");
    var site_url = '<?php echo $site_url;?>';
    var path = '<?php echo $this->config->item("path");?>';
    var id = '<?php echo $zone_id;?>';
    var s = document.createElement("script");
        s.type = "text/javascript";
        s.src = site_url+path+"?id="+id+"&width="+st[0]+"&height="+st[1];
        s.innerHTML = null;
        alert(s);}

answered Jun 22, 2017 at 6:29

Versha Gupta

2732 gold badges3 silver badges10 bronze badges

Collectives™ on Stack Overflow

Change Script tag value dynamically using javascript

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related