Passing string to javascript function parameter gets parsed as integer

Question

There are tons of questions on passing strings to a javascript function - that's not what I'm asking here. My problem is that I have to pass an integer (a customer ID) as a string to a javascript function from PHP. The reason I have to do this is sometimes a customer ID can have leading zeros, and I do not know how many leading zeros will be needed, so I can't pad or format with leading zeros in javascript.

Here's the PHP that calls my function. The $row is a resulting array from an odbc query.

parse_str("customerId=" . $row["customerId"], $output);
// This is called via AJAX, so returning HTML as response
...
echo "<td><input type='checkbox' id='" . $output["customerId"] . "' onclick='disableAccount(" . $row["userAccountId"] . ", " . $output["customerId"] . ");' checked /></td>

The above works fine, and correctly passes a string with leading zeros to the funtion. Here's part of that function.

function disableAccount(userAccountId, customerId) {
// Do stuff here
}

As an example, I have a customerId of "026608". When the disableAccount function is called, the customerId parameter is parsed as an integer, which strips the leading zero, and I now have a parameter of '26608'.

As I mentioned above, I can't use padding to add a leading zero to the customerId, as there isn't always a leading zero on the customerId. The customerId can also have more than one leading zero.

How can I get my function to parse a string, i.e. "026608" as a parameter with the leading zeros? Thanks in advance!

If it has leading zeros it's not an integer, it's a string. If you need it to process with leading zeroes, send it as a string the entire way. — Matt
– Matt, Commented Jun 21, 2017 at 20:15
Your php is not wrapping that value in quotes as it writes out the params to the onclick handler, so it will be a number. — James
– James, Commented Jun 21, 2017 at 20:16
"The above works fine, and correctly passes a string with leading zeros to the funtion." No it doesn't. — user5734311
– user5734311, Commented Jun 21, 2017 at 20:22

john Smith · Accepted Answer · 2017-06-21 20:18:09Z

3

try to pass/escape the quotes so it gets parsed as string by the js

(\"" . $row["userAccountId"] . \""

answered Jun 21, 2017 at 20:18

john Smith

18k12 gold badges80 silver badges124 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Adam Elders Over a year ago

That worked, thanks. I thought it was being passed correctly, because I'm also using this value to set the element's ID in a while loop. Since the ID was coming in correctly there, I thought it was being passed correctly to the function.

john Smith Over a year ago

you´re welcome, glad it helped ;) this way your js-function is called disableAccount("026608"... instead of disableAccount(026608...

MinistryOfChaps · Accepted Answer · 2017-06-21 20:39:56Z

1

Great spot by john Smith, also another useful function for leading zeroes (though in this instance, not more efficient than john's) is the sprintf function.

$id = 321;

function disableAccount($userAccountId, customerId)
    {
    //Result is 000321
    $userAccIdWithZeros = sprintf('%06d', $userAccountId);

    //Rest of your code...
    }

answered Jun 21, 2017 at 20:39

MinistryOfChaps

1,49219 silver badges32 bronze badges

Comments

Lee Kowalkowski · Accepted Answer · 2017-06-21 20:56:16Z

1

Use the heredoc syntax whenever you produce HTML in PHP, it's more readable:

echo <<< _
<td>
    <input type="checkbox" 
           id="{$output['customerId']}" 
           onclick="disableAccount('{$row['userAccountId']}', this.id);" 
           checked />
</td>
_;

... because you don't have to escape your quotes, and you might have spotted your issue at once.

answered Jun 21, 2017 at 20:56

Lee Kowalkowski

11.8k3 gold badges43 silver badges49 bronze badges

1 Comment

Adam Elders Over a year ago

Thanks, I did not know about that!

Collectives™ on Stack Overflow

Passing string to javascript function parameter gets parsed as integer

3 Answers 3

2 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related