JavaScript callback function

Question

please help I have a simple example here

<script type="text/javascript" language="javascript">
    function test(callback1) {
        callback1();
    }
    var f1 = function () {
        alert(1);
    }
</script>

Currently, parameter of the test function is a function, when abc button is clicked, test function will be called and then test will call f1. Everything okie with me.

However, I'd like a small change like this: parameter of the test function will be a string, I mean it should be a function name, test('f1') instead of test(f1). Is it possible?How can I implement this?

Thanks

possible duplicate of JavaScript function name as a string... — epascarello
– epascarello, Commented Dec 13, 2010 at 15:13

gertas · Accepted Answer · 2010-12-13 15:17:29Z

2

window[callback1]();

Depending on use I would prefer prepare separate functions map.

var funcMap = {
   f1: function() {...},
   ...
};
funcMap['f4'] = function() {...};
function test(callback1) {
    funcMap[callback1]();
}

It definitely doesn't bloat window namespace and is more secure (window has more methods provided by browser).

Don't use eval - it's evil!

answered Dec 13, 2010 at 15:17

gertas

17.2k1 gold badge79 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

gen_Eric · Accepted Answer · 2010-12-13 15:15:23Z

2

eval() is unneeded here. To pass a callback, just pass the function name. Functions are variables.

For example:

function test(a){
    alert(a);
}

function callback(b,a){
    b(a);
}

callback(test, 'dog'); //alerts 'dog'

So, in your code, test(f1) will work fine.

answered Dec 13, 2010 at 15:15

gen_Eric

228k42 gold badges304 silver badges343 bronze badges

Comments

Mahesh Velaga · Accepted Answer · 2010-12-13 15:09:33Z

0

You can use eval() to execute the function which is passed as a string. But its deprecated to use eval.

Example:

function test(someFunctionName) {
        eval(someFunctionName);
    }

answered Dec 13, 2010 at 15:09

Mahesh Velaga

22k5 gold badges41 silver badges60 bronze badges

3 Comments

Mahesh Velaga Over a year ago

@epascarello: I haven't used it ever in production code, so I don't know how evil it can be. But, if many wise people tried it and say it is, then I go with them :)

epascarello Over a year ago

if people say jump off a bridge because it is the quickest way down would you do it? :) Eval is slow, eval can lead to security issues, and there are better solutions.

Mahesh Velaga Over a year ago

@epascarello: I won't. I certainly don't want to re-invent the wheel, I learn from other's experience as well, otherwise you will never move forward than where others have landed in the past. I take suggestions if they make sense to me :). Also I clearly stated in my answer that eval is deprecated.

Lukas Eder · Accepted Answer · 2010-12-13 15:10:14Z

0

write something like

function test(callback1) {
    eval(callback1 + "()");
}

then callback1 should be a string

answered Dec 13, 2010 at 15:10

Lukas Eder

223k138 gold badges729 silver badges1.6k bronze badges

2 Comments

Lukas Eder Over a year ago

I know. But the pragmatic developer may always prefer evil to another 3hrs of searching :)

gertas Over a year ago

Pragmatic programmer should also educate followers by doing research, which isn't so hard here. Eval is like SQL parametrized by concatenated strings. I wouldn't call one a programmer when using them.

Collectives™ on Stack Overflow

JavaScript callback function

4 Answers 4

Comments

Comments

3 Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

3 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related