push in array of object jquery but in one object only

Question

var months_range = [];
var obj = {};
obj['weather'] = "winter";
$('input').each(function(index, obj) {
  var id = $(this).attr('id');
  obj[id] = $(this).val();
  months_range.push(
    obj
  );
});

console.log(JSON.stringify(months_range));

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<input type='text' id='jan' value='1' />

<input type='text' id='feb' value='2' />

I want to add only 1 object in my array which will contain all data I want to have in my array.

What I like to output is:

[{"jan":"1","feb":"2","weather":"winter"}]

What i get is

[{"jan":"1"},{"feb":"2"}]

You don't need months_range and remove obj from each param — Jack jdeoel
– Jack jdeoel, Commented May 29, 2017 at 10:09

Nope · Accepted Answer · 2017-05-29 10:05:10Z

Your inner obj parameter in the each is overwriting the outer obj variable. As you are not using it you can remove the parameter.

var months_range = [];
var obj = {};
obj['weather'] = "winter";
$('input').each(function(index) {
  var id = $(this).attr('id');
  obj[id] = $(this).val();
  months_range.push(
    obj
  );
});

console.log(JSON.stringify(months_range));

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<input type='text' id='jan' value='1' />

<input type='text' id='feb' value='2' />

If you only want a single object in the array at the end, only push the data into the array after the each statement, like this:

var months_range = [];
var obj = {};
obj['weather'] = "winter";
$('input').each(function(index) {
  var id = $(this).attr('id');
  obj[id] = $(this).val();
});

months_range.push(obj);

console.log(JSON.stringify(months_range));

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<input type='text' id='jan' value='1' />

<input type='text' id='feb' value='2' />

Henrik Andersson · Accepted Answer · 2017-05-29 10:06:10Z

1

You're shadowing, think overwriting, your outer obj variable with the function argument obj which makes the push operation push in a new object for each iteration. Either rename the outer variable or the function argument and it'll work, somewhat.

Furthermore you're pushing the object on to the array for each iteration which will end up giving you an N length array with duplicate objects, move the push out of the loop.

var months_range = [];
var monthsObj = {}; //Previously `obj`.
monthsObj['weather'] = "winter";
$('input').each(function(index, obj) {
  var id = $(this).attr('id');
  monthsObj[id] = $(this).val();

});
months_range.push(
  monthsObj
);

edited May 29, 2017 at 10:06

answered May 29, 2017 at 10:02

Henrik Andersson

47.5k16 gold badges102 silver badges94 bronze badges

2 Comments

Giant Over a year ago

what should i do to get the desired ouput then? also i dont get what do you mean by shadowing

Giant Over a year ago

i didnt see that one coming i didnt notice i named same obj.. i need 9 mins for upvote

Carsten Løvbo Andersen · Accepted Answer · 2017-05-29 10:05:21Z

0

Remove obj from function(index, obj) so it looks like function(index)

And move months_range.push(obj); out of the .each

var months_range = [];
var obj = {};
$('input').each(function(index) {
  var id = $(this).attr('id');
  obj[id] = $(this).val();
});
obj['weather'] = "winter";
months_range.push(
  obj
);

console.log(JSON.stringify(months_range));

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<input type='text' id='jan' value='1' />

<input type='text' id='feb' value='2' />

answered May 29, 2017 at 10:05

Carsten Løvbo Andersen

27.1k10 gold badges53 silver badges80 bronze badges

Comments

marmeladze · Accepted Answer · 2017-05-29 10:10:04Z

0

I really did not understand your question but seems that gives the result you want.

var obj = {};
obj["weather"] = "winter";

[].forEach.call(document.getElementsByTagName("input"), function(e){
  obj[e.id] = e.value;
});

console.log(obj);

<input type='text' id='jan' value='1' />

<input type='text' id='feb' value='2' />

answered May 29, 2017 at 10:10

marmeladze

6,5863 gold badges28 silver badges49 bronze badges

Collectives™ on Stack Overflow

push in array of object jquery but in one object only

4 Answers 4

Comments

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related