Trying to convert JS function into C# function

Question

I try to convert my function, which uses an RomanNumeral Input to output it as Decimal Value, from JS into C#, but somehow im stuck and really need advice on how to make this Work.

using System;
using System.Collections.Generic;

class solution
{

static int romanToDecimal(string romanNums)
{
    int result = 0; 
    int [] deci = {1000, 900, 500, 400, 100, 90, 50, 40, 10, 9, 5, 4, 1};
    string [] roman = {"M", "CM", "D", "CD", "C", "XD", "L", "XL", "X", "IX", "V", "IV", "I"};

    for (var i = 0; i < deci.Length; i++)
    {   
        while (romanNums.IndexOf(roman[i]) == 0) 
        {
            result += deci[i]; 

            romanNums = romanNums.Replace(roman[i], " "); 
        }                                               
    }                                                   
    return result;                                  
}

static void Main()
{

Console.WriteLine(romanToDecimal("V")); //Gibt 5 aus.
Console.WriteLine(romanToDecimal("XIX")); // Gibt 19 aus.
Console.WriteLine(romanToDecimal("MDXXVI"));// Gibt 1526 aus.
Console.WriteLine(romanToDecimal("MCCCXXXVII"));// Gibt 1337 aus.
}

}

Please explain why the current code doesn't work

Rob
– Rob ♦

2017-05-28 23:59:36 +00:00
Commented May 28, 2017 at 23:59 — Rob
– Rob ♦, Commented May 28, 2017 at 23:59
I don't think XD is 90.

RJM
– RJM

2017-05-29 01:16:12 +00:00
Commented May 29, 2017 at 1:16 — RJM
– RJM, Commented May 29, 2017 at 1:16
It should be XC instead

Yatin
– Yatin

2017-05-29 01:18:51 +00:00
Commented May 29, 2017 at 1:18 — Yatin
– Yatin, Commented May 29, 2017 at 1:18

Etienne · Accepted Answer · 2017-05-29 00:29:25Z

2

Replace works differently in C#, use substring to remove the first few characters matching:

    static int romanToDecimal(string romanNums)
    {
        int result = 0;
        int[] deci = { 1000, 900, 500, 400, 100, 90, 50, 40, 10, 9, 5, 4, 1 };
        string[] roman = { "M", "CM", "D", "CD", "C", "XD", "L", "XL", "X", "IX", "V", "IV", "I" };

        for (var i = 0; i < deci.Length; i++)
        {
            while (romanNums.IndexOf(roman[i]) == 0)
            {
                result += deci[i];

                romanNums = romanNums.Substring(roman[i].Length);
            }
        }
        return result;
    }

answered May 29, 2017 at 0:29

Etienne

1,1161 gold badge12 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Trying to convert JS function into C# function

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related