javascript for loop function to merge two new arrays.

Question

As part of my learning exercise, I am trying to create a function with a For loop. The function returns a new array variable merges and matches the index value of both array musicians and instruments. So the expected return should be string: "John Lennon Plays Guitar"

Here is my attempt, but I keep failing to get the return:

var musicians = ["John Lennon", "Paul McCartney", "George Harrison", "Ringo Starr"]
var instruments = ["Guitar", "Bass Guitar", "Lead Guitar", "Drums"]

  function theBeatlesPlay(musicians, instruments) {      

    for (let i=0; i<musicians.length; i++) {

      var newMusicians = musicians[i]
      var newInstruments = instruments[i]
    }

    console.log(newMusicians[i] + "plays" + instruments[i])
  }

Put the console.log inside the for loop. Also, there's no need for those variables. — Andrew Li
– Andrew Li, Commented May 25, 2017 at 5:17

JLRishe · Accepted Answer · 2017-05-25 05:20:48Z

1

You're overwriting your variables on every iteration of the loop. You need to create an empty array and fill it (and then return it):

var musicians = ["John Lennon", "Paul McCartney", "George Harrison", "Ringo Starr"]
var instruments = ["Guitar", "Bass Guitar", "Lead Guitar", "Drums"]

function theBeatlesPlay(musicians, instruments) {
  var combinations = [];

  for (let i = 0; i < musicians.length; i++) {
    combinations.push(musicians[i] + ' plays ' + instruments[i]);
  }

  return combinations;
}

console.log(theBeatlesPlay(musicians, instruments));

answered May 25, 2017 at 5:20

JLRishe

102k19 gold badges138 silver badges171 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

brk · Accepted Answer · 2017-05-25 05:56:27Z

1

Couple of issues are there.

The function need to return the merged array. Secondly the function was never called. You may not need to again create a variable inside the loop

var musicians = ["John Lennon", "Paul McCartney", "George Harrison", "Ringo Starr"]
var instruments = ["Guitar", "Bass Guitar", "Lead Guitar", "Drums"]


function theBeatlesPlay(musicians, instruments) {
  var mergedArray = [];

  for (let i = 0; i < musicians.length; i++) {
    mergedArray.push(musicians[i] + " plays " + instruments[i])

  }
  return mergedArray;

}
console.log(theBeatlesPlay(musicians, instruments))

edited May 25, 2017 at 5:56

answered May 25, 2017 at 5:23

brk

50.3k10 gold badges59 silver badges85 bronze badges

Comments

Rohìt Jíndal · Accepted Answer · 2017-05-25 12:37:31Z

Few observations as per your code :

Add ; after each statement inside for loop for good coding practices.
put console.log statement inside for loop as it will print the values iterates inside for loop.
Instead of newMusicians[i] use newMusicians in console.log.

var musicians = ["John Lennon", "Paul McCartney", "George Harrison", "Ringo Starr"]
var instruments = ["Guitar", "Bass Guitar", "Lead Guitar", "Drums"]

  function theBeatlesPlay(musicians, instruments) {      

    for (let i = 0; i < musicians.length; i++) {
      var newMusicians = musicians[i];
      var newInstruments = instruments[i];
      console.log(newMusicians + " plays " + instruments[i]);
    }
  }
  
 theBeatlesPlay(musicians, instruments);

Sandeep Nayak · Accepted Answer · 2017-05-25 05:21:15Z

-1

You need to put console.log inside the for loop.
Also, console.log(newMusicians + " plays " + instruments[i])

newMusicians instead of newMusicians[i] in while logging

var musicians = ["John Lennon", "Paul McCartney", "George Harrison", "Ringo Starr"]
var instruments = ["Guitar", "Bass Guitar", "Lead Guitar", "Drums"]

  function theBeatlesPlay(musicians, instruments) {      

    for (let i=0; i<musicians.length; i++) {

      var newMusicians = musicians[i];
      var newInstruments = instruments[i];
      console.log(newMusicians + " plays " + instruments[i])
    }

    
  }
  
  theBeatlesPlay(musicians, instruments);

answered May 25, 2017 at 5:21

Sandeep Nayak

4,7571 gold badge25 silver badges34 bronze badges

Collectives™ on Stack Overflow

javascript for loop function to merge two new arrays.

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related