Runs as a macro on visual basic for windows application - Access Database

Question

Ok I am trying to programmatically generate records for an access database, but it keeps displaying like a macro and the line of code in question shows up in red. What am I doing wrong?

Sub arrayData()
Dim custnames() As Varient
Dim num As Integer, dbs As Database, InsertRecord As String
Dim CustId As Integer, num1 As Integer
Dim CustName As String
Set dbs = CurrentDb()
CustId = 0
For num1 = 0 To 9
CustId = CustId + 1
custnames = Array("Peter", "Mary", "Frank", "Ian", "Ron", "Natalie","Radhu", "Jat", "David")
num = Int((9 - 0 + 1) * Rnd + 0)
// ERROR OCCURS ON THE LINE BELOW.
InsertRecord = "insert into CUSTOMER(CustNo,CustFName)values("&"'"&CustId&"'"&","&"'"&CustName&"'"&")"
dbs.Execute InsertRecord
Debug.Print CustId; CustName
End Sub

EDIT: Added & after CustName

You're missing an & after CustName

Nick is tired
– Nick is tired

2017-04-24 07:15:30 +00:00
Commented Apr 24, 2017 at 7:15 — Nick is tired
– Nick is tired, Commented Apr 24, 2017 at 7:15

Gustav · Accepted Answer · 2017-04-24 07:38:13Z

1

Try to write readable string concatenations. And, as CustId is numeric, no quotes:

InsertRecord = "insert into CUSTOMER (CustNo,CustFName) values (" & CustId & ",'" & CustName & "')"

answered Apr 24, 2017 at 7:38

Gustav

56.3k7 gold badges33 silver badges65 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Runs as a macro on visual basic for windows application - Access Database

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related