Correct output in if ..elif in shell scripting

Question

I have the following sell code

#!/bin/sh
echo "hello"
echo "enter the salutation $abc"
read -r abc
if [ "$abc" = "1" ]
then
 echo "Hiiii"
elif [ "$abc" = "2" ]
then
echo "haaaaa"
fi
echo "enter name $xyz"
read -r xyz
if 
if [ "$xyz" = "1" ]
then
 echo "Chris"
elif [ "$xyz" = "2" ]
then
echo "Morris"
fi
echo "you had put salutation as" "$abc"
echo "you entered name as " "$xyz"

I need the final printing to be like

 you had put salutation as Hii
 you entered name as chris

what I get is

 you had put salutation as 1
 you entered name as 1

Any help? Do I need to mention the final statement inside the if elif statement?

What did you enter when you are prompted for salutation and name respectively? — Anthony Kong
– Anthony Kong, Commented Apr 21, 2017 at 6:28
Your code in question is not complete. It throws syntax error: test.sh: line 24: syntax error: unexpected end of file. Won't produce the output you said you saw. — Anthony Kong
– Anthony Kong, Commented Apr 21, 2017 at 6:42

Liju Thomas · Accepted Answer · 2017-04-21 06:54:02Z

1

The issues are with your echo statements:

echo "Hiiii"
echo "haaaaa"
echo "Chris"
echo "Morris"

You are just printing the string but not storing it in variables which you can display as your expected output:

echo "you had put salutation as" "$abc"
echo "you entered name as " "$xyz"

The values stored in abc and xyz as you entered will be 1 and 1. Use variables to store values and display them when required. Like, replace echo's with following:

disp_sal="Hiiii" disp_sal="haaaaa"

disp_name="Chris" disp_name="Morris"

also,

echo "you had put salutation as" "$disp_sal"
echo "you entered name as " "$disp_name"

answered Apr 21, 2017 at 6:54

Liju Thomas

1,0745 gold badges18 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

clt60 · Accepted Answer · 2017-04-21 07:53:52Z

0

I would use:

#!/bin/bash

PS3="Enter the salutation>"
select abc in Hiii Haaa; do
    [[ "$abc" ]] && break
done

PS3="Enter name>"
select xyz in Chris Morris; do
    [[ "$xyz" ]] && break
done

echo "you had put salutation as" "$abc"
echo "you entered name as " "$xyz"

answered Apr 21, 2017 at 7:53

clt60

64.3k17 gold badges114 silver badges206 bronze badges

Comments

KOUSIK MANDAL · Accepted Answer · 2017-04-21 06:36:05Z

0

Try this;

#!/bin/sh
    echo "hello"
    echo "enter the salutation $abc"

    read -r abc

    if [ "$abc" = "1" ]
    then
        x="Hiiii"
    elif [ "$abc" = "2" ]
    then
        x="haaaaa"
    fi

    echo "enter name $xyz"

    read -r xyz

    if [ "$xyz" = "1" ]
    then
         y="Chris"
    elif [ "$xyz" = "2" ]
    then
         y="Morris"
    fi
    echo "you had put salutation as" "$x"
    echo "you entered name as " "$y"

answered Apr 21, 2017 at 6:36

KOUSIK MANDAL

2,0421 gold badge24 silver badges51 bronze badges

Collectives™ on Stack Overflow

Correct output in if ..elif in shell scripting

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related