Run JavaScript function onLoad in a Rails view?

Question

my rails view looks like this (it is a partial):

=javascript_include_tag :defaults

#scroller
 -@other_images.each do |img|
  .thumbnail_wrapper
    .thumbnail_image
      =image_tag img.image.url(:thumbnail), :class => 'button', :onClick => "replaceImg(#{img.id});",  :onLoad => "setLastID(#{ @other_images[0].id });"

I want to call the function setLastID(#{ @other_images[0].id }); only once, when the whole view loads. However, I couldn't figure out how... this was the only place I could put it where it worked. But now it's been called each time within the loop... Help!!

aceofspades · Accepted Answer · 2010-12-02 22:39:33Z

1

This is an example where you want to dynamically generate the javascript in the partial, since ruby variables are required. As long as these sorts of calls are very short, I'm fine with it.

=javascript_include_tag :defaults

#scroller
 -@other_images.each do |img|
  .thumbnail_wrapper
    .thumbnail_image
      =image_tag img.image.url(:thumbnail), :class => 'button', :onClick => "replaceImg(#{img.id});"

:javascript
  setLastID(#{@other_images[0].id});

answered Dec 2, 2010 at 22:39

aceofspades

7,5861 gold badge37 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

mtay Over a year ago

Thank you fullware, but I tried this and for some reason it isn't working for me. I know because even putting a simple alert in there does nothing. Any idea why??

mtay Over a year ago

That view is being loaded by Ajax like this: new Ajax.Updater(this.scroller, url); (by a direct url) Is this somehow stopping direct javascript functions?

Samo · Accepted Answer · 2010-12-07 17:14:30Z

1

Have you considered loading a js.erb template instead? You can add to the dom using javascript instead of haml, and you still have access to your Rails variables. If you don't need to use that javascript function setLastID() anywhere else, you can define it right there in your js.erb template instead of some javascript file. If you do need it elsewhere, then make sure that your javascript file is loaded correctly. Reference the file in your layout, and then in the javascript file, just do something like this:

$(document).ready(function() {
  alert("I'm loaded!");
});

answered Dec 7, 2010 at 17:14

Samo

8,24013 gold badges63 silver badges96 bronze badges

Comments

Keith Gaddis · Accepted Answer · 2010-12-02 20:35:15Z

-1

Do it unobtrusively. tag your last image with a class (we'll use "button-last" for the sake of argument) and put it in the document.ready() event in a javascript behind the scenes, like application.js (this works if you're using jquery, you'd need to translate it to your framework of choice):

$(document).ready(function(){
  setLastID($("img.button-last").attr("id"));
});

answered Dec 2, 2010 at 20:35

Keith Gaddis

4,11326 silver badges20 bronze badges

2 Comments

mtay Over a year ago

Thank you, that is very useful... but I'd rather have access to the attribute @other_images rather than the id of the last image that loads (I've noticed these aren't always sequential). How can I call @other_images from here?

mtay Over a year ago

Also, it doesn't seem like the $(document).ready(function() can tell when I've loaded new partials into different divs on my page... but that's when I want the event to trigger.

Collectives™ on Stack Overflow

Run JavaScript function onLoad in a Rails view?

3 Answers 3

2 Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related