passing parameter to javascript method

Question

i have html code like:

<button type="button" class="button button-raised larger" onclick="app.shareOnIg();">Share on Instagram</button>&nbsp;
                                    </div>

 <script type="text/javascript">
        app.initialize();
    </script>

js looks like:

var app = {
    // Application Constructor
    initialize: function() {
        this.bindEvents();
    },
    bindEvents: function() {
        document.addEventListener('deviceready', this.onDeviceReady, false);
    },
shareOnIg: function () {
        Instagram.share('picture', 'example', function (err) {
                        });
    }
};

I want to replace example with actual value dynamically. plz advise how. I tried to add a parameter in the function and modified the call like

 <button type="button" class="button button-raised larger" onclick="app.shareOnIg(" + myparam + ");">Share on Instagram</button>&nbsp;
                                        </div>

but this did not work

I'd suggest to use addEventListener to bind event from JavaScript. To pass parameter from onclick, you need to wrap the string in quotes onclick="myFun('" + param + '"); — Tushar
– Tushar, Commented Apr 4, 2017 at 6:05
the variable myparam is global ? If variable is global you can use it like that: onclick="app.shareOnIg(myparam);" — Alisher Gafurov
– Alisher Gafurov, Commented Apr 4, 2017 at 6:09
@Alisher Gafurov if you reply it as answer i can mark it correct — Vik
– Vik, Commented Apr 4, 2017 at 6:29

Alisher Gafurov · Accepted Answer · 2017-04-04 06:34:54Z

1

In this case all is correct. One problem is the how is passed the variable myparam. If the variable is global, we can little modify the code to:

<button type="button" class="button button-raised larger" onclick="app.shareOnIg(myparam);">Share on Instagram</button>&nbsp;
                                </div>

just change:

 onclick="app.shareOnIg(" + myparam + ");"

to:

onclick="app.shareOnIg(myparam);"

answered Apr 4, 2017 at 6:34

Alisher Gafurov

4475 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Fida · Accepted Answer · 2017-04-04 06:10:36Z

1

var app = {
shareOnIg: function (value) {
  console.log(value);
        Instagram.share('picture', value, function (err) {
                        });
    }
};

 <button type="button" class="button button-raised larger" onclick="app.shareOnIg( 'This is the passed Value');">Share on Instagram</button>&nbsp;

answered Apr 4, 2017 at 6:10

Fida

1,3581 gold badge12 silver badges21 bronze badges

Comments

brk · Accepted Answer · 2017-04-04 06:09:44Z

0

It seems you need to pass an argument to shareOnIg function

shareOnIg: function (data) {
   // console.log(data) here to see the parameter passed from the thml
   Instagram.share('picture', 'example', function (err) {});
    }

answered Apr 4, 2017 at 6:09

brk

50.3k10 gold badges59 silver badges85 bronze badges

Comments

Jai · Accepted Answer · 2017-04-04 06:13:19Z

0

Instead go unobtrusive:

var app = {
  // Application Constructor
  initialize: function() {
    this.bindEvents();
  },
  bindEvents: function() {
    var btns = document.querySelectorAll('.button');
    document.addEventListener('deviceready', this.onDeviceReady, false);
    btns.forEach((btn)=>btn.addEventListener('click', this.shareOnIg.bind(myparam)));
  },
  shareOnIg: function(param) {
    Instagram.share('picture', 'example', function(err) {});
  }
};

answered Apr 4, 2017 at 6:13

Jai

74.8k12 gold badges77 silver badges104 bronze badges

Comments

David · Accepted Answer · 2017-04-04 06:15:27Z

0

What about this?

  <input type="text" value="John" id="name">
  
  <button onclick="sayHi('name')">Say Hi</button>
  <script>
    function sayHi(control) {
      var e = document.getElementById(control);
      console.log(e.value);
    }
  </script>

answered Apr 4, 2017 at 6:15

David

566 bronze badges

Comments

Manngo · Accepted Answer · 2017-04-04 06:17:26Z

You will find it much easier in the long run to dispense with onclick attributes and to write proper event handlers. Below is an example of how it can be done.

<button type="button" id="doit" … > … </button>

document.addEventListener("DOMContentLoaded",function() {
    var button=document.querySelector('button#doit');
    button.addEventListener('click',function() {
        app.shareOnIg(myparam);
    }, false);
}, false);

var app = {
    // Application Constructor
        initialize: function() {
            this.bindEvents();
        },
        bindEvents: function() {
            document.addEventListener('deviceready', this.onDeviceReady, false);
        },
        shareOnIg: function (something) {   //  new parameter
            Instagram.share('picture', something, function (err) {

            }
        }
};

The solution to your question is to add a parameter variable in your shareOnIg method, and call the method when the tmie comes.

In the above rewrite, I have

given the button an id to make it findable
added some behaviour to the DOMContentLoaded event which triggers when the page has loaded enough for the DOM to be ready
in the behaviour, I have located the button using its id and attached a function to its click event.

Collectives™ on Stack Overflow

passing parameter to javascript method

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related