Javascript nested functions return

Question

With consideration of the following code-block, how would one go about having loadConfig() return the JSON config object?

function loadConfig(){
  fs.readFile('./config.json', 'utf8', function (err, data){
    if (err) throw err;
    var config = JSON.parse(data); 
  });
  return config;
};

The returned config is undefined as the variable config is outside the scope of the loadConfig() function, yet if the the return statement is located inside the readFile anonymous function, it doesn't fall through to loadConfig(), and seemingly only breaks the nested anonymous function.

Another attempt has been made to resolve this by saving the anonymous function in a variable which is then returned by the main function loadConfig, but to no avail.

function loadConfig(){
  var config = fs.readFile('./config.json', 'utf8', function (err, data){
    if (err) throw err;
    var config = JSON.parse(data);
    return config;
  });
  return config;
};

The question stands; given situation sketched above, how would one make loadConfig() return the config JSON object?

readFile is async - so you'll never be able to return from that function. — tymeJV
– tymeJV, Commented Mar 17, 2017 at 18:20
stackoverflow.com/questions/10058814/get-data-from-fs-readfile — Elliot Rodriguez
– Elliot Rodriguez, Commented Mar 17, 2017 at 18:21

caisah · Accepted Answer · 2017-03-17 18:24:21Z

3

Just define/use a promise:

function loadConfig(){
  return new Promise(function(resolve, reject) {
    fs.readFile('./config.json', 'utf8', function (err, data){
      if (err) reject(err);

      var config = JSON.parse(data);
      resolve(config); 
    });
  })
};

and to use it:

loadConfig().then(function(config) {
  // do something with the config
}).catch(function(err){
  // do something with the error
});

answered Mar 17, 2017 at 18:24

caisah

2,0961 gold badge22 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Abhinav Over a year ago

this is best way to do it, or use success

lux Over a year ago

So I cannot just have a global variable with the config object which I can refer to whenever I want; I need to use the configVar.then(...); to access the config object I take it as I cannot just return the input to the "then function". Am I correct in this?

caisah Over a year ago

You can have a global variable, but because the action is asynchronous you don't know when that variable is being populated. By using then you avoid this, because as soon as the config is set, you can use it in the next function. This is called a promise or a future (in other languages) and is the idiomatic way of dealing with asynchronous actions. You are basically returning a function which you can use it immediately after it has some result. Please read more here developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/…

Abhinav · Accepted Answer · 2017-03-17 18:22:35Z

0

Simple answer is you can't.

These are async call, which mean your return statement will not wait for your response, it will continue to execute. Hence when you call function your return statement is fired first and then you receive the response.

Instead, use success callback function for your operation and not return value..

answered Mar 17, 2017 at 18:22

Abhinav

1,2001 gold badge8 silver badges12 bronze badges

Comments

ajai Jothi · Accepted Answer · 2017-03-17 18:43:53Z

0

Use readFileSync instead of readFile. Since readFile is an async mthod.

function loadConfig(){
  var fileContent = fs.readFile('./config.json', 'utf8').toString();
  return fileContent?JSON.parse(fileContent):null;
};

answered Mar 17, 2017 at 18:43

ajai Jothi

2,3041 gold badge10 silver badges16 bronze badges

Comments

Tom · Accepted Answer · 2017-03-17 18:22:47Z

-2

You can also use the synchronous version of readFile or yes, Promise is the other solution. Doc here: https://nodejs.org/api/fs.html#fs_fs_readfilesync_file_options

answered Mar 17, 2017 at 18:22

Tom

132 bronze badges

2 Comments

Abhinav Over a year ago

using sync call is not at all recommended, this will hangup your browser and will make page unresponsive.

Elliot Rodriguez Over a year ago

this is a blocking call and a terrible idea, async all the way

Collectives™ on Stack Overflow

Javascript nested functions return

4 Answers 4

3 Comments

Comments

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related