BASH - curl command not work into loop with for

Question

i need check status of some link listen in a file called paths.txt, i have write a simple for loop but not work

for LINK in $(cat paths.txt)
do
  CURL="$(curl -I $LINK 2>/dev/null | head -n 1 | cut -d$' ' -f2)"
  if [ "${CURL}" = "200" ]
  then
    echo ${LINK} >> true.txt
  else
    echo ${LINK} >> false.txt
  fi
done

If i launch the curl command from terminal i read the right status, instead if i make an echo of CURL variable i not have any output

instead of CURL="$(curl -I $LINK 2>/dev/null | head -n 1 | cut -d$' ' -f2)", do echo $LINK. Do you get the proper content of your file ? — Aserre
– Aserre, Commented Mar 9, 2017 at 13:58
yes, i have tried and work, i have insert echo -e "\n$LINK\n" and show correctly all link sepatared by line — stecog
– stecog, Commented Mar 9, 2017 at 13:59
are there any spaces or special characters (like * or ?) in the URLs? — marek.jancuska
– marek.jancuska, Commented Mar 9, 2017 at 14:01

Rik Tytgat · Accepted Answer · 2017-03-09 14:00:38Z

2

Run the script like this: bash -x myscript and watch the executed commands.

answered Mar 9, 2017 at 14:00

Rik Tytgat

1466 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

stecog Over a year ago

i have found a \r at the end of any link, i have correct the file format and now works perfectly, thanks!

chepner Over a year ago

This isn't really an answer; it's a general comment that can direct one to the answer.

beliy · Accepted Answer · 2017-03-09 15:26:13Z

0

don't use cat in bash scripts, because is bad practice and can be problems with big files.

SCRIPTDIR=`dirname -- "$0"`
for siteUrl in $( < "$SCRIPTDIR/paths.txt")
do
    if [[ -z "$siteUrl" ]]; then break; fi
    if [[ "$(curl --write-out "%{http_code}\n" --silent --output /dev/null ${siteUrl} )" = "200" ]];  then
        echo ${siteUrl} >> true.txt
    else
        echo ${siteUrl} >> false.txt
    fi
done

answered Mar 9, 2017 at 15:26

beliy

4456 silver badges14 bronze badges

Collectives™ on Stack Overflow

BASH - curl command not work into loop with for

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related