array_push() function not working in Laravel

Question

I'm developing a web application in Laravel. The below code is not from the application but gives you a simple idea of the problem I am having.

The following code works

public $my_users = [];  //This is outside function

$users = [];
$users = User::all();
$this->my_users = $users;

That's pretty simple, works fine. However, i want to be able to loop through all of the users and add ones of my choosing like so:

public $my_users = [];  //This is outside function

$users = [];
$all_users = User::all();
foreach ($all_users as $user)
{
    array_push($users, $user);
}
$this->my_users = $users;

Again, what I am doing here has no logic behind it, it's just an example.

In this case both pieces of code should have the same result. However, the second piece of code isn't working. It seems to be the array_push function that isn't working here. is there any reason why this is? What am I to do here?

It seems like you are looping through an array to create another array and then assigning in the global array. Why you are doing that? Instead can't you directly assign the array? — masud_moni
– masud_moni, Commented Mar 2, 2017 at 6:04
I feel like there's something missing here. There's no part of either snippets that should be failing unless the users table is empty (in which case the first snippet will have an object and the second one an empty array). — apokryfos
– apokryfos, Commented Mar 2, 2017 at 6:48

SteD · Accepted Answer · 2017-03-02 06:04:30Z

3

User::all(); returns a type collection (Illuminate\Database\Eloquent\Collection). So first block of code you delcared an array $users = []; and immediately override it with:

$this->my_users = User::all();

So you're basically assigning a collection to $this->my_users.

2nd block of code you are looping through the collection and assign it to the array.

$this->my_users = [
   //instance of App\User 1,
   //instance of App\User 2 etc
];

Try dd the result and you should be able to see a clearer picture.

answered Mar 2, 2017 at 6:04

SteD

14.1k13 gold badges69 silver badges77 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Alex Naughton Over a year ago

So what I need to do is create an instance of a collection and then add to that collection. Do you know how to do this? I've tried $users = new \Illuminate\Database\Eloquent\Collection; didn't work.

SteD Over a year ago

You can just add it to a normal array and convert it to collection by doing collect($usersArray)

Alex Naughton Over a year ago

I don't understand what you mean. I have a collection all_users, how do I create another collection so I can add specific users from the all_users collection to it? I can't add instances of all_users to an array.

SteD Over a year ago

Any reason you would want to add a collection into another collection? Anyway you can do $newCollection = collect(); to create a new collection. Then you can use $newCollection->push($all_users);

apokryfos · Accepted Answer · 2017-03-02 06:43:14Z

1

Laravel's query results are always a collection so if filtering is what you really need then do:

$users = Users::all()->filter(function ($u) { /* conditions to accept the user */ });

answered Mar 2, 2017 at 6:43

apokryfos

40.9k11 gold badges85 silver badges128 bronze badges

Comments

Shubham Bansal · Accepted Answer · 2017-03-02 06:10:28Z

0

You could use the default helper of the Laravel instead of array_push

array_add()

See the documentation here: https://laravel.com/docs/5.4/helpers#method-array-add

answered Mar 2, 2017 at 6:10

Shubham Bansal

6067 silver badges7 bronze badges

Comments

vans · Accepted Answer · 2017-03-02 06:17:35Z

-1

$users.push($user); i think this is how you push into your array

answered Mar 2, 2017 at 6:17

vans

113 bronze badges

2 Comments

apokryfos Over a year ago

It's not though

vans Over a year ago

my bad. that's how you do it in javascript but not in laravel i guess

Collectives™ on Stack Overflow

array_push() function not working in Laravel

4 Answers 4

4 Comments

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

4 Comments

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related