Create array from another array if values are same

Question

I have the following array -

Array
(
    [31] => Array
        (
            [0] => 3
            [1] => 3
        )
    [33] => Array
        (
            [0] => 2
            [1] => 1
        )
)

Now for the key 31 both of the elements has same value ie 3 but not for the key 33. So I am trying to create another array which will look like.

Array
(
    [31] =>  same
    [33] =>  notsame       
)

That means if a key from multidimensional array has got all the values same then it will have the text 'same' else 'notsame'

My code-

foreach($subvaluesArr as $k1=>$v1) //$subvaluesArr is the multidimensional array here
    {
        foreach($v1 as $k2=>$v2)
        {           
             if($v1[$k2] = $v1[$k2+1])
            {
                $newArr[$k1] = 'same';
            }
            else
            {
                $newArr[$k1] = 'notsame';
            }
        }
    }

    echo '<pre>';
    print_r($newArr);
    echo '</pre>';

And the output is showing 'notsame' for both keys.

Array
(
    [31] => notsame
    [33] => notsame
)

Any help is highly appreciated.

use === in if statement.

Ataur Rahman
– Ataur Rahman

2017-02-12 10:04:03 +00:00
Commented Feb 12, 2017 at 10:04 — Ataur Rahman
– Ataur Rahman, Commented Feb 12, 2017 at 10:04
@AtaurRahman tried but didn't work.

Prithviraj Mitra
– Prithviraj Mitra

2017-02-12 10:06:04 +00:00
Commented Feb 12, 2017 at 10:06 — Prithviraj Mitra
– Prithviraj Mitra, Commented Feb 12, 2017 at 10:06

Olaf Dietsche · Accepted Answer · 2017-02-12 10:28:13Z

1

When you run this snippet, you will get this error

Notice: Undefined index: 2 in /in/bcqEH on line 14

See https://3v4l.org/bcqEH

This is because the code tries to compare first and second, and it tries to compare second and third element. But this third element doesn't exist. This means the comparison fails and sets the value to notsame.

To fix this, you could just compare the first two elements, e.g.

foreach ($subvaluesArr as $k1 => $v1) {
    if ($v1[0] == $v1[1]) {
        $newArr[$k1] = 'same';
    } else {
        $newArr[$k1] = 'notsame';
    }
}

When you really have more than two elements, you might try array_unique

foreach ($subvaluesArr as $k1 => $v1) {
    $u = array_unique($v1);
    if (count($u) == 1) {
        $newArr[$k1] = 'same';
    } else {
        $newArr[$k1] = 'notsame';
    }
}

edited Feb 12, 2017 at 10:28

answered Feb 12, 2017 at 10:16

Olaf Dietsche

74.4k9 gold badges113 silver badges214 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Prithviraj Mitra Over a year ago

Thanks but the array could have more than 2 elements. That's why I was doing +1 thing.

Prithviraj Mitra Over a year ago

Brilliant solution. Working great. Thanks a lot Olaf.

Ataur Rahman · Accepted Answer · 2017-02-12 10:15:36Z

0

You have to break; loop after running the if-else condition. example :

foreach($subvaluesArr as $k1=>$v1) //$subvaluesArr is the multidimensional array here
{
    foreach($v1 as $k2=>$v2)
    {           
         if($v1[$k2] === $v1[$k2+1])
        {
            $newArr[$k1] = 'same';
        }
        else
        {
            $newArr[$k1] = 'notsame';
        }
        break;
    }
}

answered Feb 12, 2017 at 10:15

Ataur Rahman

1,8311 gold badge16 silver badges12 bronze badges

1 Comment

Prithviraj Mitra Over a year ago

If the array has more than 2 elements then adding break doesn't work.

insider · Accepted Answer · 2017-02-12 10:17:29Z

0

cant comment so I write it as answer. In your loop when you hit last element of an array, you ask

if($v1[$k2] == $v1[$k2+1])

where $v1[$k2+1] is "undefined" as you are out of bounds. So this last element is always false and you end up with "notsame"

answered Feb 12, 2017 at 10:17

insider

3622 silver badges5 bronze badges

Collectives™ on Stack Overflow

Create array from another array if values are same

3 Answers 3

2 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related