async.each doesn't run callback function

Question

I'm trying to do something after push data from reddit api to array, but callback function doesn't work at all. As you see the code, It's supposed to print Callback function works! but It doesn't. Is there any ideas about this?

let optForReddit = {
  method: 'GET',
  uri: 'https://www.reddit.com/domain/eroshare.com/new.json',
  json: true
}

  rp(optForReddit)
    .then(function(redditJSON) {
      let posts = redditJSON.data.children;
      let len = posts.length;
      let eroJson = [];
      async.each(posts, function(item, callback) {
          if (isVideo(item.data.url)) {
            eroJson.push(getAlbumId(item.data.url));
          }
      },    
      function(err) {
          console.log("Callback function works");
          if(err) console.log(err);
      });
    })
    .catch(function(err) {
      console.log(err);
    })

Asif Saeed · Accepted Answer · 2017-02-12 07:42:26Z

1

async.each(posts, function(item, callback) {
      if (isVideo(item.data.url)) {
        eroJson.push(getAlbumId(item.data.url));
      }
      callback();  // this callback is for informing that i am done processing one item in array.
  },    
  function(err) {
      //this function will be invoked when the callback() in the above body was called maximum time(e.g posts.length times)
      console.log("Callback function works");
      if(err) console.log(err);
  });

this is because you are not calling callback function each time. callback when called tells the async function that i am done with the current execution and call next iteraion. You never called the callback().

edited Feb 12, 2017 at 7:42

answered Feb 12, 2017 at 7:29

Asif Saeed

2,05516 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

boombamboo Over a year ago

but I want to call the callback function after the each loop is done. how can I do?

Asif Saeed Over a year ago

like you want to execute loop serially? so it executes in order?

boombamboo Over a year ago

yes! so the callback function can run after everything is done.

boombamboo Over a year ago

I solved the problem! I just had to use eachSeries not each. Thank you for help anyways!

boombamboo Over a year ago

I have a question, eachSeries in waterfall would work or not?

|

Collectives™ on Stack Overflow

async.each doesn't run callback function

1 Answer 1

10 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

10 Comments

Your Answer

Sign up or log in

Post as a guest

Related