PHP not updating MySQL Table

Question

I am new to PHP and want to create a script that will update the users first and last name if they need to do so. I have the code below and it ends up echoing out UPDATE fixableusers SET first='trenton' WHERE id='6' on the settings.inc.php page but it is not updating the table. Is there a reason it is not updating the table?

<?php
include_once('dbh.php');

session_start();
$userSession = $_SESSION['id'];

if(isset($_SESSION['id'])) {
    $postTest = $_POST['first'];
    $sql = "UPDATE fixableusers SET first='$postTest' WHERE id='$userSession'";
} else {
    echo 'Do something else';
}

My dbh.php file includes the following code:

<?php

$conn = mysqli_connect('localhost', 'root', 'root', 'users');

please use prepared statements to fix your sql injection vunlerability ( malicious things passed in post ). There's no point in not making a good habit starting now. — erik258
– erik258, Commented Dec 23, 2016 at 3:26

Naga · Accepted Answer · 2016-12-23 04:10:18Z

5

You are excluding the mysqli_query function,

Add this mysqli_query($conn, $sql); after build the $sql.

edited Dec 23, 2016 at 4:10

answered Dec 23, 2016 at 3:25

Naga

2,1683 gold badges18 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Taki · Accepted Answer · 2016-12-23 03:28:28Z

1

Inside your if statement you're just declaring variables, in order to actually execute a query you need to :
if(isset($_SESSION['id'])) { $postTest = $_POST['first']; $sql = "UPDATE fixableusers SET first='$postTest' WHERE id='$userSession'"; mysqli_query($conn, $sql); }

And you need to improve this ( handle errors ..etc)

edited Dec 23, 2016 at 3:28

user7328204

answered Dec 23, 2016 at 3:22

Taki

17.7k5 gold badges28 silver badges48 bronze badges

Comments

Karthik · Accepted Answer · 2016-12-23 09:09:16Z

1

<?php
// Connect your DB
include_once('dbh.php');

//Start Session    
session_start();

if(isset($_SESSION['id'])) {

// Update Query
$updateqry = "UPDATE fixableusers SET first='".$_POST['first']."' WHERE id='".$_SESSION['id']."'";
mysqli_query($conn, $updateqry);

} else {

        echo 'Do something else';
}

?>

edited Dec 23, 2016 at 9:09

answered Dec 23, 2016 at 4:40

Karthik

5,77718 gold badges50 silver badges88 bronze badges

1 Comment

beerwin Over a year ago

Please add some explanation to the code so the OP and further readers can understand your code. The OP is a beginner and so are many others on this site.

Collectives™ on Stack Overflow

PHP not updating MySQL Table

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related