Adding variables to jquery selectors

Question

How can I add variables into my selectors :

function addCurrentClass(){
    var loc = window.location;
    $('#nav li a[href = "' + loc + '"]').addClass('currentpage');
}

I've tried many variations of the above using different types of selectors and can't get it to change to the value contained in var loc.

Any ideas?

Thanks

Guffa · Accepted Answer · 2010-11-08 07:01:10Z

2

You should use window.location.href rather than window.location to get the url, however the main problem with the approach is probably that it only works if you have fully qualified URLs in your link tags. Local or relative URLs won't work.

answered Nov 8, 2010 at 7:01

Guffa

703k111 gold badges760 silver badges1k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

patnz Over a year ago

Thanks, working now, it's a rough approach I know, but can't do things properly serverside in this case. I guess I could use :contains(<?$_SERVER[REQUEST_URI]?>) ..hmm...

MD Sayem Ahmed · Accepted Answer · 2010-11-08 06:55:38Z

0

How about this -

function addCurrentClass(){
    var loc = window.location.toString();
    $('#nav li a[href = "' + loc + '"]').addClass('currentpage');
}

I think you need to convert the location into string before you can get the string URL. Details are here.

answered Nov 8, 2010 at 6:55

MD Sayem Ahmed

29.3k27 gold badges115 silver badges183 bronze badges

Collectives™ on Stack Overflow

Adding variables to jquery selectors

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related