How to declare a function in angularjs

Question

I have a function and i did it in this way

JS :

function updateInstitution (isValid) {alert('hi')
    if (!isValid) {
        $scope.$broadcast('show-errors-check-validity', 'vm.form.institutionForm');
        return false;
    }
    var data = JSON.stringify(vm.institution);
    httpService.put('institutions/' + vm.institution_id, data).then(function (results) {
        if (results && results.data && results.data.details) {
            vm.institution = results.data.details;
            formInstitutionData('profile');
            commonService.showNotification('success', 'Institution Details updated successfully!');
            $('#institutionModal').modal('hide');    
        }   
    });     
} 
}
  vm.updateInstitution = updateInstitution;

Html :

<button type="button" class="btn btn-blue"  ng-click="vm.updateInstitution(vm.form.institutionForm.$valid)" ng-bind="field.saveText"></button>

But i am getting the error as

updateInstitution is not defined

Can anyone please suggest help.Thanks.

JS :

    (function () {
  'use strict';

  // Institutions controller
  angular
          .module('institutions')
          .controller('InstitutionsController', InstitutionsController);

  InstitutionsController.$inject = ['$scope', '$state', '$window', '$timeout', 'httpService', 'Authentication', 'commonService'];



    function active() {
      httpService.get('institutions/' + vm.institution_id).then(function (results) {
        if (results && results.data && results.data.details) {
          vm.institutionCopyData = angular.copy(results.data.details);
          formInstitutionData('all');
        }
      });
    }

    $scope.editInstitutionModal = function (type) {
      $scope.field = {};
      $scope.showInstitutionModal = false;
      if (type === 'basicedit') {
            $scope.field.field_type = 'edit-institution.form.client';
            $scope.field.formName = 'Edit institution (' + vm.institutionObj.name + ')';
            $scope.field.saveText = 'Update';  
      }
      if(type === 'general'){
            $scope.field.field_type = 'add-general.form.client';
            $scope.field.formName = 'General Info';
            $scope.field.saveText = 'Save';          
      }
      $timeout(function () {
        $scope.showInstitutionModal = true;
        $('#institutionModal').modal('show');
        $scope.$apply();
      }, 10);
    };


    function updateInstitution (isValid) {alert('hi')
        if (!isValid) {
            $scope.$broadcast('show-errors-check-validity', 'vm.form.institutionForm');
            return false;
        }
        var data = JSON.stringify(vm.institution);
        httpService.put('institutions/' + vm.institution_id, data).then(function (results) {
            if (results && results.data && results.data.details) {
                vm.institution = results.data.details;
                formInstitutionData('profile');
                commonService.showNotification('success', 'Institution Details updated successfully!');
                $('#institutionModal').modal('hide');    
            }   
        });     
    } 
    }
  }
}());

But i am getting the error as

updateInstitution is not defined

Can anyone please suggest help.Thanks.

But i am getting the error as

updateInstitution is not defined

Can anyone please suggest help.Thanks.

Have you defined the "controller as" definition then only can use in this way? — Vinod Louis
– Vinod Louis, Commented Nov 22, 2016 at 9:19
What about the context of the function definition? Could you maybe create a fiddle with your current state? — bash0ne
– bash0ne, Commented Nov 22, 2016 at 9:24
var updateInstitution = function(isValid) { /* your functions body */ } — gaurav bhavsar
– gaurav bhavsar, Commented Nov 22, 2016 at 9:26

Matheno · Accepted Answer · 2016-11-22 09:26:23Z

5

You should declare the following in your controller:

var vm = this;
vm.updateInstitution = updateInstitution;

answered Nov 22, 2016 at 9:26

Matheno

4,2126 gold badges40 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Matheno Over a year ago

Can you post the whole code of your directive, or recreate the situation in a fiddle ? This is not enough info for us.

Matheno Over a year ago

I also see an extra }. Maybe you're closing your controller already before defining the bindables.

Matheno Over a year ago

No prob, hope we could help.

MostafaMashayekhi · Accepted Answer · 2016-11-22 09:26:12Z

0

you use $scope.updateInstitution instead of function updateInstitution() , because communication bridge between html and controller is $scope, or for use vm.function you defined $scope.vm

edited Nov 22, 2016 at 9:26

answered Nov 22, 2016 at 9:23

MostafaMashayekhi

29.2k3 gold badges23 silver badges40 bronze badges

1 Comment

MMR Over a year ago

but here i am declaring function in js

Aniket B · Accepted Answer · 2016-11-22 09:20:28Z

-1

 $scope.updateInstitution = function(){
     //Your code
  }

answered Nov 22, 2016 at 9:20

Aniket B

4881 gold badge5 silver badges14 bronze badges

1 Comment

Vinod Louis Over a year ago

do you see the ng-click as vm.updateInstitution how this will call the function ?

Collectives™ on Stack Overflow

How to declare a function in angularjs

3 Answers 3

3 Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related