PHP snippet Code Security

Question

I am writing this in PHP

$edit_window = $database_info->timestamp + 86400;
$current_timestamp = time ();

if ($current_timestamp > $edit_window){
        $database_info->editable = TRUE;
     } 
else {
        $database_info->editable = FALSE;
     }

then

if ($database_info->editable){
//do some major stuff
}

Somehow this code is worrying me. Is it open to vulnerablities? Is there a better approach?

Peter C · Accepted Answer · 2010-10-31 01:01:57Z

1

It doesn't look vulnerable. Are you storing any user-provided data in the database (or inserting it into HTML) or relying on cookies or headers that could be spoofed?

answered Oct 31, 2010 at 1:01

Peter C

6,2971 gold badge28 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Mr Hyde Over a year ago

Well the database timestamp itself is created programmatically, but the current code is called by passing parameters in url, something like example.com/auth?some_id_parameter=3453656

Eugene Over a year ago

Perhaps you want to make sure the parameters are "sanitized"...ie. not an invalid timestamp? (Pretty vague question=P)

Mr Hyde Over a year ago

I guess that my concerns are ill-founded. Thanks

Peter C Over a year ago

Just validate the some_id_parameter to make sure it's what you think it is (an integer) and you'll be fine.

Collectives™ on Stack Overflow

PHP snippet Code Security

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related