Execute String In Javascript Without Eval

Question

I have done it with eval but I read that eval is evil. So I am curious: how do I write this without eval()?. I already tried some sample but it didn't work. Is it possible to do this without eval or is eval the only way?

$(".test").each(function(){
    var xyz = "";
    var w = $(this).last().attr("name");
    for(var i=0; i< (w-1);i++){
        var xyz = xyz + ".prev()";
    }
    var x = '$(this).first().parent()' + xyz;
    var y = x + '.find("td.one").attr("rowspan",'+w+');';
    eval(y);    
});

nnnnnn · Accepted Answer · 2016-10-25 02:37:53Z

2

eval() isn't evil, it's just almost always the wrong tool for the job. For example, your algorithm can be implemented without messing around with strings at all, so then you wouldn't need to consider eval():

$(".test").each(function(){
    var w = $(this).attr("name");
    var el = $(this).parent();
    for(var i=0; i < w-1; i++){
        el = el.prev();
    }
    el.find("td.one").attr("rowspan", w);
});

Note also that your use of .last() and .first() was redundant, because within your .each() loop this will refer to a single DOM node.

edited Oct 25, 2016 at 2:37

answered Oct 25, 2016 at 2:32

nnnnnn

150k30 gold badges210 silver badges247 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Execute String In Javascript Without Eval

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related