Problem with using javascript to insert <input> tags in html

Question

I am trying to take text that is in an array (one word per value) and insert it into html. All the code is here: http://jsfiddle.net/chromedude/r6wVq/3/.

Update: My question is what am I doing wrong? It does not do anything which is weird.

Just for everybody who was wondering what this code is supposed to help me do is memorize long passages for school.

You have a syntax error... you have to wrap the <input> element into single quotes: extPrelim = '<input type="text"></input>' If you then run the code, your browser crashes ;) In general, the code seems to be strange, e.g. you call Math.floor() without passing a value and blanks seems to be always empty, so the for loops will never run. — Felix Kling
– Felix Kling, Commented Oct 21, 2010 at 21:53
@Pekka exactly. sorry about that I meant to ask. I will update the question above. — chromedude
– chromedude, Commented Oct 21, 2010 at 21:53

Felix Kling · Accepted Answer · 2010-10-21 22:14:21Z

4

You have an infinite loop, that's why the browser crashes:

for (i = 0; i < text.length; i++) {
    var currentText = text[i];
    for (i = 0; i<blanks.length; i++){}
}

The second loop always resets the counter variable i to 0. If you have nested loops you have to use different variables. And use var to declare the variables as local, e.g.

for (var i = 0; i < text.length; i++) {
    var currentText = text[i];
    for ( var j = 0; j<blanks.length; j++){
    }
}

Same for your most outer for loop!

I don't know exactly what you want to achieve with the code, but here are some comments:

var blankNum = Math.random(Math.floor() * (text.length / 2));

Math.random takes no parameter, but Math.floor does.

for (i = 0; i < blanks.length; i++) {

blanks is still empty at this point, so the loop will never run.

if (currentText==blanks[i]){

Are you sure that blanks[i] will contain text? The previous mentioned (never running) loop seems to add numbers to the array.

 textPrelim = <input type="text"></input>

You get a syntax error here, you must enclose the string into quotes.

edited Oct 21, 2010 at 22:14

answered Oct 21, 2010 at 22:04

Felix Kling

820k181 gold badges1.1k silver badges1.2k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

chromedude Over a year ago

thanks, I completely messed up on the math.random(math.floor part I meant for it to be the other way around.

Community · Accepted Answer · 2017-05-23 12:18:38Z

3

I fixed your fiddle: http://jsfiddle.net/yEKPt/1/

What was wrong:

for iterator scope (here)

This line (27) threw a syntax error:

textPrelim = <input type="text"></input> //Needs to be quoted.

Should be:

textPrelim = '<input type="text"></input>'; //Quoted.

You reversed Math.random and Math.floor (lines 8, 14). (See: Math.Random(), Math.Floor())
```
var blank = Math.random(Math.floor() * (text.length / 2));
```

Check out my revised version. I think it accomplishes what you were looking for?

edited May 23, 2017 at 12:18

CommunityBot

11 silver badge

answered Oct 21, 2010 at 22:20

clarkf

3,04223 silver badges14 bronze badges

1 Comment

Felix Kling Over a year ago

Good job! :)... @chromedude: I suggest to accept this as answer.

MBO · Accepted Answer · 2010-10-21 22:14:36Z

1

With addition to Felix's answer, try to check your code at http://www.jslint.com for syntax errors and undeclared (implicitly global) variables.

answered Oct 21, 2010 at 22:14

MBO

31.2k5 gold badges52 silver badges52 bronze badges

Collectives™ on Stack Overflow

Problem with using javascript to insert <input> tags in html

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related